Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.4
    • Component/s: General
    • Labels:
      None
    • Number of attachments :
      1

      Description

      I would like to tune our checkstyle settngs. One change is to not complain about empty blocks as long as there is SOME text in there. That allows us to have an empty block as long as we put a comment in there about why it's empty.

      I would like to remove module name="DesignForExtension" – its checks are so stringent that it generates more noise than useful signal. It makes it impossible to have a mostly-checkstyle-complaint-free codebase.

      I was hoping we could change the max line length from 90 to 100. It makes a LOT of warnings go away, and forcing line folding at 90 reduces readability (IMO)

      I was hoping we could add the following checks:

      <module name="TodoComment">
      <property name="format" value="FIXME:"/>
      </module>
      <module name="TodoComment">
      <property name="format" value="TEMP:"/>
      </module>
      <module name="ParameterAssignment">
      <property name="severity" value="info"/>
      </module>
      <module name="MultipleVariableDeclarations">
      <property name="severity" value="info"/>
      </module>
      <module name="MultipleStringLiterals">
      <metadata name="com.atlassw.tools.eclipse.checkstyle.lastEnabledSeverity" value="info"/>
      <property name="severity" value="ignore"/>
      </module>
      <module name="ModifiedControlVariable">
      <property name="severity" value="info"/>
      </module>
      <module name="JUnitTestCase"/>
      <module name="FinalLocalVariable">
      <metadata name="com.atlassw.tools.eclipse.checkstyle.lastEnabledSeverity" value="info"/>
      <property name="severity" value="ignore"/>
      <property name="tokens" value="PARAMETER_DEF,VARIABLE_DEF"/>
      </module>
      <module name="CovariantEquals"/>
      <module name="JavadocStyle"/>

      Rather than attach a patch, I'm just going to attach my propsoed src/tools/checkstyle/castor-main-checks.xml

      Thoughts?

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Edward Kuns
            Reporter:
            Edward Kuns
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: