castor

Split "main" out of SourceGenerator.java

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.0.3
  • Fix Version/s: 1.0.4
  • Component/s: XML code generator
  • Labels:
    None
  • Number of attachments :
    2

Description

Split main() out of SourceGenerator.java to streamline the code. Creading a new source file that will contain only main(). For backwards compatibility, SourceGenerator.java will have a tiny "main()" that delegates to the new file.

  1. File
    srcgen-invoker.diff
    03/Oct/06 4:31 PM
    57 kB
    Edward Kuns
  2. File
    final-c1608-patch.diff
    05/Oct/06 2:57 PM
    69 kB
    Edward Kuns

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Edward Kuns added a comment -

Attached is a patch to break the "main" for srcgen into a separate class. What do you think?

Show
Edward Kuns added a comment - Attached is a patch to break the "main" for srcgen into a separate class. What do you think?
Hide
Permalink
Werner Guttmann added a comment -

Go ahead and commit as is (we can always change the name of the new *Invoker class to something more menaningful at a later time).. Having said that, we now need to adopt various scripts to make sure that they call the main() method on the new class.

In addition, why not mark the new main() method on the SourceGenerator as deprecated to point users to the new one ... ?

Show
Werner Guttmann added a comment - Go ahead and commit as is (we can always change the name of the new *Invoker class to something more menaningful at a later time).. Having said that, we now need to adopt various scripts to make sure that they call the main() method on the new class. In addition, why not mark the new main() method on the SourceGenerator as deprecated to point users to the new one ... ?
Hide
Permalink
Edward Kuns added a comment -

Final patch applied. About to commit.

Show
Edward Kuns added a comment - Final patch applied. About to commit.
Hide
Permalink
Edward Kuns added a comment -

Commit done. I updated all scripts calling SourceGenerator and I updated all docs I could find that reference the command line, except for the PDF. Do we have the source to the PDF?

Show
Edward Kuns added a comment - Commit done. I updated all scripts calling SourceGenerator and I updated all docs I could find that reference the command line, except for the PDF. Do we have the source to the PDF?
Hide
Permalink
Ralf Joachim added a comment -

As far as I know we don't have the source of the pdf. Some time ago Werner requested it from the author but I think without success. IMHO we have to move documentation of source generator to html. Having said that it is not yet decided if we stay with current XML documentation format, move over to xdoc or something supported by maven or use confluence (http://docs.codehaus.org/display/CASTOR/Home).

Show
Ralf Joachim added a comment - As far as I know we don't have the source of the pdf. Some time ago Werner requested it from the author but I think without success. IMHO we have to move documentation of source generator to html. Having said that it is not yet decided if we stay with current XML documentation format, move over to xdoc or something supported by maven or use confluence ( http://docs.codehaus.org/display/CASTOR/Home ).
Hide
Permalink
Werner Guttmann added a comment -

NO, I have actually been sent the sources by Arnaud. I still have to make it available by checking it in. Though I don't really like the idea of checking a Winword file in, to be honest.

Show
Werner Guttmann added a comment - NO, I have actually been sent the sources by Arnaud. I still have to make it available by checking it in. Though I don't really like the idea of checking a Winword file in, to be honest.
Hide
Permalink
Edward Kuns added a comment -

How about we convert the WinWord document to OpenOffice format?

Show
Edward Kuns added a comment - How about we convert the WinWord document to OpenOffice format?
Hide
Permalink
Werner Guttmann added a comment -

Sure, could do ... . But looking at this document, I'd rather extract the information available as part of this doument, and make it available as part of the HTML docs. Let me atach the document here, and you guys let me know what you think of this, okay ?

Show
Werner Guttmann added a comment - Sure, could do ... . But looking at this document, I'd rather extract the information available as part of this doument, and make it available as part of the HTML docs. Let me atach the document here, and you guys let me know what you think of this, okay ?
Hide
Permalink
Edward Kuns added a comment -

Moving the Word document into the current Castor documentation standard format is a better idea, of course.

Show
Edward Kuns added a comment - Moving the Word document into the current Castor documentation standard format is a better idea, of course.

People

  • Assignee:
    Edward Kuns
    Reporter:
    Edward Kuns
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: