castor

ComplexType-DirectAccess test fails complaining about differences

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.0.3
  • Fix Version/s: 1.0.4
  • Component/s: XML tests
  • Labels:
    None
  • Number of attachments :
    1

Description

When the "name" element of either Root or Data objects either begins or ends with a space, the space is not preserved. This causes the test failure. One of two things will fix this:

1) Change the random string so that it will not begin or end with blanks.

2) Change the marshaling to preserve leading and trailing whitespace.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Werner Guttmann added a comment -

I'd rather prefer the former approach, to be honest.

Show
Werner Guttmann added a comment - I'd rather prefer the former approach, to be honest.
Hide
Permalink
Edward Kuns added a comment -

Attached is a patch (on top of my change from CASTOR-1590) that modifies the random string generator to – by default – return "collapsed" strings suitable for use in XML. I provided an option so one could request random strings that allow leading or trailing spaces and that allow consecutive blanks in the string.

Assuming in the default case we won't want to require preserve-whitespace for tests to pass, however, I did as you prefer. (It was definitely the easier change to make.)

Show
Edward Kuns added a comment - Attached is a patch (on top of my change from CASTOR-1590 ) that modifies the random string generator to – by default – return "collapsed" strings suitable for use in XML. I provided an option so one could request random strings that allow leading or trailing spaces and that allow consecutive blanks in the string. Assuming in the default case we won't want to require preserve-whitespace for tests to pass, however, I did as you prefer. (It was definitely the easier change to make.)

People

  • Assignee:
    Ralf Joachim
    Reporter:
    Edward Kuns
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: