Details

    • Type: Sub-task Sub-task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.3
    • Fix Version/s: 1.0.4
    • Component/s: XML code generator
    • Labels:
      None
    • Number of attachments :
      2
    1. javasource.diff
      32 kB
      Edward Kuns
    2. testing.tar.gz
      2 kB
      Edward Kuns

      Activity

      Hide
      Werner Guttmann added a comment -

      Setting this to resolved .... just to get the code improvements in as early as possible. I am sure we'll be talking about the tests ....

      Show
      Werner Guttmann added a comment - Setting this to resolved .... just to get the code improvements in as early as possible. I am sure we'll be talking about the tests ....
      Hide
      Werner Guttmann added a comment -

      Edward, in general, it makes sense to add/move unit tests for the javasource package to src/test/java. In this particular case, I am not sure, though. For a couple of reasons, to be honest

      a) mid- to -long-term, I thin we should move away from these classes and move to a template engine such as e.g. velocity.
      b) some of these tests need to be Java 5.0-specific, which causes a quite a problem.

      Having said that, I will commit the clean-up(s) as is ...

      Show
      Werner Guttmann added a comment - Edward, in general, it makes sense to add/move unit tests for the javasource package to src/test/java. In this particular case, I am not sure, though. For a couple of reasons, to be honest a) mid- to -long-term, I thin we should move away from these classes and move to a template engine such as e.g. velocity. b) some of these tests need to be Java 5.0-specific, which causes a quite a problem. Having said that, I will commit the clean-up(s) as is ...
      Hide
      Edward Kuns added a comment -

      That patch is for
      org/exolab/castor/util/DTDResolver.java

      Show
      Edward Kuns added a comment - That patch is for org/exolab/castor/util/DTDResolver.java
      Hide
      Edward Kuns added a comment -

      A trivial cleanup patch (too trivial to attach as a file) is below. I noticed this when adding a @see to this method from somewhere else.

      Index: DTDResolver.java
      ===================================================================
      — DTDResolver.java (revision 6224)
      +++ DTDResolver.java (working copy)
      @@ -243,7 +243,7 @@
      }

      /**

      • * Resolves public&szstem ids to files stored within the JAR.
        + * Resolves public & system ids to files stored within the JAR.
        *
      • @see org.xml.sax.EntityResolver#resolveEntity(java.lang.String,
      • java.lang.String)
      Show
      Edward Kuns added a comment - A trivial cleanup patch (too trivial to attach as a file) is below. I noticed this when adding a @see to this method from somewhere else. Index: DTDResolver.java =================================================================== — DTDResolver.java (revision 6224) +++ DTDResolver.java (working copy) @@ -243,7 +243,7 @@ } /** * Resolves public&szstem ids to files stored within the JAR. + * Resolves public & system ids to files stored within the JAR. * @see org.xml.sax.EntityResolver#resolveEntity(java.lang.String, java.lang.String)
      Hide
      Edward Kuns added a comment -

      Let me know if the form of TestJAnnotatedElementHelper.java is useful, or if (for example) it would be more useful to search for specific substrings rather than compare the entire string generated. If these sorts of tests are useful, we can probably remove the main() routines from a lot of the javasource files and use JUnit instead to test it,

      Show
      Edward Kuns added a comment - Let me know if the form of TestJAnnotatedElementHelper.java is useful, or if (for example) it would be more useful to search for specific substrings rather than compare the entire string generated. If these sorts of tests are useful, we can probably remove the main() routines from a lot of the javasource files and use JUnit instead to test it,
      Hide
      Edward Kuns added a comment -

      Added attachment to add two JUnit test case files under src/test/java/org/exolab/javasource

      Let me know if the sort of JUnit test case in TestJAnnotatedElementHelper.java would be useful to complete and if that sort of work would be useful to continue.

      Show
      Edward Kuns added a comment - Added attachment to add two JUnit test case files under src/test/java/org/exolab/javasource Let me know if the sort of JUnit test case in TestJAnnotatedElementHelper.java would be useful to complete and if that sort of work would be useful to continue.
      Hide
      Edward Kuns added a comment -

      Added attachment for minor changes to javasource package.

      Show
      Edward Kuns added a comment - Added attachment for minor changes to javasource package.

        People

        • Assignee:
          Werner Guttmann
          Reporter:
          Edward Kuns
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: