castor
  1. castor
  2. CASTOR-1552

Improvement of the CollectionInfo

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.3
    • Fix Version/s: 1.0.4
    • Component/s: XML code generator
    • Labels:
      None
    • Testcase included:
      yes
    • Number of attachments :
      1

      Description

      The CollectionInfo and its subclasses contain a lot of duplicate code. Especially CollectionInfo and CollectionInfoJ2 reimplement methods with completely identical code.

      Also some attributes of the CollectionInfo are unnecessary since the information is already stored in other attributes or the FieldInfo Superclass.
      The subclasses of CollectionInfo also directly write a protected attribute of CollectionInfo.

        Activity

        Hide
        Werner Guttmann added a comment -

        Now if only I knew why there's no patch (yet) .. ?

        Show
        Werner Guttmann added a comment - Now if only I knew why there's no patch (yet) .. ?
        Hide
        Steven Dolg added a comment -

        Refactoring of the CollectionInfo, CollectionInfoJ2, and CollectionInfoODMG30.

        Changed name of the generated method "remove(int index)" for collection types to "removeAt(int index)" to prevent name clashes with method "remove(Type value)" when using a collection with ype int.

        Show
        Steven Dolg added a comment - Refactoring of the CollectionInfo, CollectionInfoJ2, and CollectionInfoODMG30. Changed name of the generated method "remove(int index)" for collection types to "removeAt(int index)" to prevent name clashes with method "remove(Type value)" when using a collection with ype int.

          People

          • Assignee:
            Werner Guttmann
            Reporter:
            Steven Dolg
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 30 minutes
              30m