castor

Mapping of a map with a nested map

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.0.2, 1.0.3
  • Fix Version/s: 1.0.4
  • Component/s: XML
  • Labels:
    None
  • Environment:
    Gentoo x86, Eclipse 3.2
  • Testcase included:
    yes
  • Number of attachments :
    5

Description

I tried to marshal the following map with a nested map:

TreeMap<String, TreeMap<String, String>>

The result is this exception:

org.exolab.castor.mapping.MappingException: The return type for method public java.lang.Object org.exolab.castor.mapping.MapItem.getValue() does not match the declared field type java.util.Map
at org.exolab.castor.mapping.loader.AbstractMappingLoader.findAccessor(AbstractMappingLoader.java:991)
at org.exolab.castor.mapping.loader.AbstractMappingLoader.createFieldHandler(AbstractMappingLoader.java:744)
at org.exolab.castor.mapping.loader.AbstractMappingLoader.createFieldDesc(AbstractMappingLoader.java:550)
at org.exolab.castor.xml.XMLMappingLoader.createFieldDesc(XMLMappingLoader.java:371)
at org.exolab.castor.mapping.loader.AbstractMappingLoader.createFieldDescs(AbstractMappingLoader.java:440)
at org.exolab.castor.mapping.loader.AbstractMappingLoader.createDescriptor(AbstractMappingLoader.java:298)
at org.exolab.castor.xml.XMLMappingLoader.createDescriptor(XMLMappingLoader.java:228)
at org.exolab.castor.xml.XMLMappingLoader.createFieldDesc(XMLMappingLoader.java:483)
at org.exolab.castor.mapping.loader.AbstractMappingLoader.createFieldDescs(AbstractMappingLoader.java:440)
at org.exolab.castor.mapping.loader.AbstractMappingLoader.createDescriptor(AbstractMappingLoader.java:298)
at org.exolab.castor.xml.XMLMappingLoader.createDescriptor(XMLMappingLoader.java:228)
at org.exolab.castor.mapping.loader.AbstractMappingLoader.loadMappingInternal(AbstractMappingLoader.java:190)
at org.exolab.castor.mapping.loader.AbstractMappingLoader2.loadMapping(AbstractMappingLoader2.java:140)
at org.castor.mapping.MappingUnmarshaller.getMappingLoader(MappingUnmarshaller.java:132)
at org.castor.mapping.MappingUnmarshaller.getMappingLoader(MappingUnmarshaller.java:99)
at org.exolab.castor.xml.Marshaller.setMapping(Marshaller.java:565)
at explorations.TreeMapWithTreeMap.testMarshalling(TreeMapWithTreeMap.java:48)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at junit.framework.TestCase.runTest(TestCase.java:154)
at junit.framework.TestCase.runBare(TestCase.java:127)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:118)
at junit.framework.TestSuite.runTest(TestSuite.java:208)
at junit.framework.TestSuite.run(TestSuite.java:203)
at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:128)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)

  1. Text File
    patch_1551_20060924.txt
    24/Sep/06 11:09 AM
    106 kB
    Steven Dolg
  2. Text File
    patch_1551_20060925.txt
    25/Sep/06 12:42 PM
    22 kB
    Steven Dolg
  3. Text File
    patch.c1551.20060925.txt
    25/Sep/06 5:44 AM
    109 kB
    Werner Guttmann
  4. Java Source File
    TreeMapWithTreeMap.java
    14/Sep/06 6:09 AM
    1 kB
    Ontje Lünsdorf
  5. File
    TreeMapWithTreeMap.mapping
    14/Sep/06 6:10 AM
    0.9 kB
    Ontje Lünsdorf

Issue Links

is depended upon by

Sub-task - The sub-task of the issue CASTOR-1584 Refactor AbstractMappingLoader

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. CASTOR-1313 Cannot unmarshall HashMap with multivalued value

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Werner Guttmann added a comment -

Thanks, Brian, for pointing this out. To be honest, I think that a solution should be possible without having to add new classes for collections and arrays. So let's address this through this issue (CASTOR-1551) only for the time being.

Show
Werner Guttmann added a comment - Thanks, Brian, for pointing this out. To be honest, I think that a solution should be possible without having to add new classes for collections and arrays. So let's address this through this issue ( CASTOR-1551 ) only for the time being.
Hide
Permalink
Ontje Lünsdorf added a comment -

Hi, Werner

the workaround using a hashtable is ok. So I'd like to reduce its priority, but never having used jira before I don't know what to do... I guess from the worklog that I can't modify this issue?

(Sorry for being a noob

Show
Ontje Lünsdorf added a comment - Hi, Werner the workaround using a hashtable is ok. So I'd like to reduce its priority, but never having used jira before I don't know what to do... I guess from the worklog that I can't modify this issue? (Sorry for being a noob
Hide
Permalink
Werner Guttmann added a comment -

Reduced the priority of this issue due to an existing work-around ... (as requested by Ontje himself).

Show
Werner Guttmann added a comment - Reduced the priority of this issue due to an existing work-around ... (as requested by Ontje himself).
Hide
Permalink
Werner Guttmann added a comment -

Steven, didn't you tell me the other day that you have a patch ready ? I am more than willing to move your JUnit test to the CTF suite, if that's what the remaining issue is ... .

Show
Werner Guttmann added a comment - Steven, didn't you tell me the other day that you have a patch ready ? I am more than willing to move your JUnit test to the CTF suite, if that's what the remaining issue is ... .
Hide
Permalink
Steven Dolg added a comment -

Patch resolving that issue.

The MapItem is excluded from the type-safety check, as it is used to represent the contents of a Map and therefor must use Object for its attributes.

Additionally I refactored the AbstractMappingLoader.

The patch is relative to src and contains a JUnit test for marshalling and unmarshalling

  • a Map containing Maps
  • a Map containing Collections
  • a Map containing Arrays (String[])
  • a Map containing Maps containing Maps

Werner, the CTF test is really missing. Actually I didn't find the time (and mood) to get to know this and didn't want to delay the patch any longer...
So thanks for volunteering.

As far as I see this could very well also fix 1175 and 1313.
Perhaps you could check this, too?

Show
Steven Dolg added a comment - Patch resolving that issue. The MapItem is excluded from the type-safety check, as it is used to represent the contents of a Map and therefor must use Object for its attributes. Additionally I refactored the AbstractMappingLoader. The patch is relative to src and contains a JUnit test for marshalling and unmarshalling a Map containing Maps a Map containing Collections a Map containing Arrays (String[]) a Map containing Maps containing Maps Werner, the CTF test is really missing. Actually I didn't find the time (and mood) to get to know this and didn't want to delay the patch any longer... So thanks for volunteering. As far as I see this could very well also fix 1175 and 1313. Perhaps you could check this, too?
Hide
Permalink
Ralf Joachim added a comment -

Steven, I like your refactoring of AbstractMappingLoader and your test cases to the map issue. I also expect that your patch to fix the issue is valid. The only problem is that it is quite difficult to see which changes to AbstractMappingLoader are related to the refactoring and what you have changed to fix the issue. I would prefer to see such changes separated into 2 issues and patches. This would make review a lot easier. In addition it may get very hard to find the reason for a different behaviour of AbstractMappingLoader if such a issue would apear sometime later.

Show
Ralf Joachim added a comment - Steven, I like your refactoring of AbstractMappingLoader and your test cases to the map issue. I also expect that your patch to fix the issue is valid. The only problem is that it is quite difficult to see which changes to AbstractMappingLoader are related to the refactoring and what you have changed to fix the issue. I would prefer to see such changes separated into 2 issues and patches. This would make review a lot easier. In addition it may get very hard to find the reason for a different behaviour of AbstractMappingLoader if such a issue would apear sometime later.
Hide
Permalink
Steven Dolg added a comment -

Hi Ralf!

I totally agree. Somehow I got carried away.

After creating the patch, I realized that this was quite a lot of changes for one patch - sorry for that. I'll try to do better in the future.

Show
Steven Dolg added a comment - Hi Ralf! I totally agree. Somehow I got carried away. After creating the patch, I realized that this was quite a lot of changes for one patch - sorry for that. I'll try to do better in the future.
Hide
Permalink
Werner Guttmann added a comment -

Steven's patch amended in that the tests relative to src/bugs have been moved to src/tests/xml.

Show
Werner Guttmann added a comment - Steven's patch amended in that the tests relative to src/bugs have been moved to src/tests/xml.
Hide
Permalink
Steven Dolg added a comment -

As requested, a minimal patch containing the necessary changes only.
Including the CTF tests from Werner.
Relative to src.

Show
Steven Dolg added a comment - As requested, a minimal patch containing the necessary changes only. Including the CTF tests from Werner. Relative to src.
Hide
Permalink
Werner Guttmann added a comment -

FYI: had to change a statement in MapOfArrays.java to Arrays.toList(Object).toString(), as Arrays.toString(Object[]) has only beed added with Java 5.0. In other words, please make sure you use Java 1.4 when compiling and testing code.

Show
Werner Guttmann added a comment - FYI: had to change a statement in MapOfArrays.java to Arrays.toList(Object).toString(), as Arrays.toString(Object[]) has only beed added with Java 5.0. In other words, please make sure you use Java 1.4 when compiling and testing code.
Hide
Permalink
Werner Guttmann added a comment -

Patch committed as is (well, apart from the little Java 1.4 vs 5.0 issue .. ). I'd still appreciate any patch for the relevant XML HOW-TO ...

Show
Werner Guttmann added a comment - Patch committed as is (well, apart from the little Java 1.4 vs 5.0 issue .. ). I'd still appreciate any patch for the relevant XML HOW-TO .. .
Hide
Permalink
Ralf Joachim added a comment -

Thank you Steven for the additional work to pull out the necessary changes only into a separate patch.

Steven or Werner, do one of you take care not to loose the great refactoring of AbstractMappingLoader included in the earlier patches or shell I take it?

Show
Ralf Joachim added a comment - Thank you Steven for the additional work to pull out the necessary changes only into a separate patch. Steven or Werner, do one of you take care not to loose the great refactoring of AbstractMappingLoader included in the earlier patches or shell I take it?
Hide
Permalink
Werner Guttmann added a comment -

Ralf, I guess (hope) Steven will provide us with a new patch for the AbstractMappingLoader, which I shall take care fo once he's provided it .. .

Show
Werner Guttmann added a comment - Ralf, I guess ( hope ) Steven will provide us with a new patch for the AbstractMappingLoader, which I shall take care fo once he's provided it .. .

People

  • Assignee:
    Steven Dolg
    Reporter:
    Ontje Lünsdorf
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: