castor

Move "query" attribute to <query> child element of named-query

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.0.3
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    1

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Emir Causevic added a comment -

For the resolution CASTOR-1499 was used an out-of-date patch.
The right patch was http://jira.codehaus.org/secure/attachment/22078/patch.c1481.20060805.patch.
This patch is cumulative, it contains implementation of named-queries (with proper "query" element placement) as well as named-native-queries at "class" level, original test cases for both of the query types and fixed mapping files.

Werner, I will try to prepare patch over the weekend, since I suppose this one is not useful anymore.

Show
Emir Causevic added a comment - For the resolution CASTOR-1499 was used an out-of-date patch. The right patch was http://jira.codehaus.org/secure/attachment/22078/patch.c1481.20060805.patch . This patch is cumulative, it contains implementation of named-queries (with proper "query" element placement) as well as named-native-queries at "class" level, original test cases for both of the query types and fixed mapping files. Werner, I will try to prepare patch over the weekend, since I suppose this one is not useful anymore.
Hide
Permalink
Werner Guttmann added a comment -

Thanks in advance, Emir, I knew that this separation of work items would cause some overhead for you, but I think it will make it easier to introduce features separatedly (iow, as they become available).

Show
Werner Guttmann added a comment - Thanks in advance, Emir, I knew that this separation of work items would cause some overhead for you, but I think it will make it easier to introduce features separatedly (iow, as they become available).
Hide
Permalink
Emir Causevic added a comment -

Fixed the mapping.xsd and mapping.dtd.
Fixed a small typo in TestNamedQuery.java.
Fixed mapping.xml for the relevant tests.
Run relevant tests: passed.

Show
Emir Causevic added a comment - Fixed the mapping.xsd and mapping.dtd. Fixed a small typo in TestNamedQuery.java. Fixed mapping.xml for the relevant tests. Run relevant tests: passed.
Hide
Permalink
Emir Causevic added a comment -

Provided a patch to fix the placing of query element.

Show
Emir Causevic added a comment - Provided a patch to fix the placing of query element.
Hide
Permalink
Werner Guttmann added a comment -

Thanks, Emir. I'll review and apply in due time ... . Having said that, we normally do not close Jira issues until after a successful commit .. .

Show
Werner Guttmann added a comment - Thanks, Emir. I'll review and apply in due time ... . Having said that, we normally do not close Jira issues until after a successful commit .. .

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Emir Causevic
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: