Details
Bug
Closed
Major
Description
We're currently hacking together the EHCache version of Castor's impl - only it's broken. The following errors exist in EHCache.java
- The initialize method is missing. This is because the parent's AbstractBaseCache initialize ends up being the visible one. Add the following:
public void initialize(final Properties params) throws CacheAcquireException
{ initialize(IMPLEMENTATION, params); }and your actual initializer will get called.
- Errors during initialization: - TYPES_NO_PARAM doesn't work; remove it. getMethod(String) should be used anywhere it was used, without parameters applied.
- In EHCache 1.2, at least - I haven't tested older versions - the net.sf.ehcache.Element.getObjectValue() doesn't exist - you want getValue().
- Error in get: NPEs when things don't exist.
- You'll note that elementInCache is not null checked; but null is a valid response for when there is no cache entry. You need to test for null
before calling _getObjectValueMethod.invoke()
Any chance of getting this into 1.0.2?
Activity
Looks like I missed something else.
Element objects are held in cache and can be retained, even though they're not actually purged from the system yet and may be expired.
That means that when you fetch the Element object, you must test it to see if it's up to date before returning it.
To do this:
1) Up at the top, under _getValueMethod
/** The method to test whether or not an element is expired. */
private Method _isExpiredMethod;
2) in the initializer, just under the _getValueMethod setup,
_isExpiredMethod = _elementClass.getMethod("isExpired", null);
3) In the get() call, the contents of the try should look like
Object elementInCache = _getMethod.invoke(_cache, new Object[]
);
if (elementInCache == null)
if (_isExpiredMethod.invoke(elementInCache, null)==Boolean.FALSE)
result = _getValueMethod.invoke(elementInCache, null);
You'll probably want to write a test case that explicitly creates an entry, clears the cache, and then uses isCached() to test to see whether or not it's cached. If you're lucky, it'll start working for you. 
I don't know, but it's possible that other caches will have similar behaviour, and expect you to be responsible for testing the difference between something-in-cache-but-expired and something-missing-from-cache.
I'm afraid I'm in no position to do so - I can't do the additional testing and the rest of it, as I'm trying to get out of my current job; as such, my ability to work on third-party projects in any real capacity is in limbo, and I can't do the necessary checkout. As it is, I'm stuck perusing files via the SVN HTTP interface on codehaus. 
Hi Gregory, I'll try to resolve this for 1.0.2 with some help from your side.