castor

Unable to regenerate mapping

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.0.1
  • Fix Version/s: 1.0.2
  • Component/s: XML code generator
  • Labels:
    None
  • Number of attachments :
    1

Description

When executing 'build gen.mapping' a NullPointerExceptio is thrown and mapping classes are not generated.

The NullPointerException is thrown at XmlBindingComponent.getCollectionType() line 1204. The method looks like:

public String getCollectionType() {
String result = null;
if (_type == MEMBER)

{ result = _member.getCollection().toString(); }
return result;
}

The problem is that _member.getCollection() returns null. If you change method to:

public String getCollectionType() {
String result = null;
if ((_type == MEMBER) && (_member.getCollection() != null)) { result = _member.getCollection().toString(); }

return result;
}

The NullPointerException does not happen any more and source is generated. What I'm not able to tell if generated code looks and works like it should. I guess this problem has been introduced with changes to castor-1470 even if the part where I aplied the fix has not been changed with it.

Issue Links

is related to

New Feature - A new feature of the product, which has yet to be developed. CASTOR-1470 Java 5 compatible code generatedfrom Castor xml

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ralf Joachim added a comment -

Having said that I set priority to blocker as I fear that sourcegen always fails when using a binding file.

Show
Ralf Joachim added a comment - Having said that I set priority to blocker as I fear that sourcegen always fails when using a binding file.
Ralf Joachim made changes -
Field Original Value New Value
Link This issue is related to CASTOR-1470 [ CASTOR-1470 ]
Hide
Permalink
Werner Guttmann added a comment -

No, it does not. I have got plenty of test cases in use currently where a binding file is being used. Let me have a look at this in some more detail ....

Show
Werner Guttmann added a comment - No, it does not. I have got plenty of test cases in use currently where a binding file is being used. Let me have a look at this in some more detail ....
Hide
Permalink
Werner Guttmann added a comment -

Ralf, I think your patch is a valid patch, in that it fixes the problem. I agree that it would be ideal to realize as to why this happens, but as I am touching the source generator quite frequently these days, I am more than happy with this patch (especially in the context of the comment of this method). Btw, the problem happens on the <Mapping> type definition, which uses an unbounded reference to specify a list of class mappings. In other words, this might be related to using this construct only, as it does not happen with 'vanilla' <xs:sequences>

In addition, I think that we should change our property definitions in src/build.xml to using $

{basedir}

as reference point (explicitly).

Show
Werner Guttmann added a comment - Ralf, I think your patch is a valid patch, in that it fixes the problem. I agree that it would be ideal to realize as to why this happens, but as I am touching the source generator quite frequently these days, I am more than happy with this patch (especially in the context of the comment of this method). Btw, the problem happens on the <Mapping> type definition, which uses an unbounded reference to specify a list of class mappings. In other words, this might be related to using this construct only, as it does not happen with 'vanilla' <xs:sequences> In addition, I think that we should change our property definitions in src/build.xml to using $ {basedir} as reference point (explicitly).
Hide
Permalink
Werner Guttmann added a comment -

Ralf, can you please commit this patch as is ?

Show
Werner Guttmann added a comment - Ralf, can you please commit this patch as is ?
Werner Guttmann made changes -
Assignee Werner Guttmann [ wguttmn ] Ralf Joachim [ rjoachim ]
Hide
Permalink
Ralf Joachim added a comment -

Final patch.

Show
Ralf Joachim added a comment - Final patch.
Ralf Joachim made changes -
Attachment patch-C1483-20060801.txt [ 21983 ]
Ralf Joachim made changes -
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Werner Guttmann made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Ralf Joachim
    Reporter:
    Ralf Joachim
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: