castor

SourceCodeGenerator ignores -nomarshall, -testable options (Regression bug)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0
  • Fix Version/s: 1.0.2
  • Component/s: XML code generator
  • Labels:
    None
  • Environment:
    Linux, JDK 1.4, Castor 1.0
  • Number of attachments :
    2

Description

Versions previous to 1.0 final (all milestone releases) do not have this problem.

With versions 1.0+, all SourceGenerator options that depend on the sourceFactory being set (not null) are ignored.

The setters for certain options do null checks on the sourceFactory, which doesn't seem to get set until generateSource() is later called.

  1. Text File
    patch.c1477.20060802.txt
    02/Aug/06 4:10 AM
    7 kB
    Werner Guttmann
  2. Text File
    patch-C1477-20060725.txt
    25/Jul/06 5:11 PM
    5 kB
    Ralf Joachim

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. CASTOR-1346 notifyPropertyChangeListeners not called when bound properties is set true.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Werner Guttmann made changes -
Field Original Value New Value
Assignee Werner Guttmann [ wguttmn ]
Hide
Permalink
Werner Guttmann added a comment -

Jason, can you please attach a small JUnit test case that highlights your problem ? The better I can replay your problem (with as little work on my side as possible), the faster I can provide a possible reply to you.

Show
Werner Guttmann added a comment - Jason, can you please attach a small JUnit test case that highlights your problem ? The better I can replay your problem (with as little work on my side as possible), the faster I can provide a possible reply to you.
Hide
Permalink
Werner Guttmann added a comment -

I am not 100% sure, but it may be that CASTOR-1477 is related to the patch provided above.

Show
Werner Guttmann added a comment - I am not 100% sure, but it may be that CASTOR-1477 is related to the patch provided above.
Ralf Joachim made changes -
Link This issue is related to CASTOR-1346 [ CASTOR-1346 ]
Ralf Joachim made changes -
Assignee Werner Guttmann [ wguttmn ] Ralf Joachim [ rjoachim ]
Hide
Permalink
Werner Guttmann added a comment -

It looks like CASTOR-1346 has introduced a regression bug that prevents command line parameters from being recognized properly.

Show
Werner Guttmann added a comment - It looks like CASTOR-1346 has introduced a regression bug that prevents command line parameters from being recognized properly.
Hide
Permalink
Ralf Joachim added a comment -

Attached patch should now again pass all commandline parameters to SourceFactory except of "testable".

I commented out line 329 of SourceGenerator which would pass the "testable" parameter to SourceFactory as this would cause 10 failing tests of CTF. It seams that to me that compilations of the generated classes fail if "testable" is enabled at CTF tests. I only see 2 reasons how this could happen:

1. "testable" has never been passed offer to SourceFactory
2. another patch has caused that the methods generated with "testable" enabled do not compile any more

If anyone else is able to resolve this problem we are able to continue and resolve this issue.

Show
Ralf Joachim added a comment - Attached patch should now again pass all commandline parameters to SourceFactory except of "testable". I commented out line 329 of SourceGenerator which would pass the "testable" parameter to SourceFactory as this would cause 10 failing tests of CTF. It seams that to me that compilations of the generated classes fail if "testable" is enabled at CTF tests. I only see 2 reasons how this could happen: 1. "testable" has never been passed offer to SourceFactory 2. another patch has caused that the methods generated with "testable" enabled do not compile any more If anyone else is able to resolve this problem we are able to continue and resolve this issue.
Ralf Joachim made changes -
Attachment patch-C1477-20060725.txt [ 21806 ]
Ralf Joachim made changes -
Description
Versions previous to 1.0 final (all milestone releases) do not have this problem.

With versions 1.0+, all SourceGenerator options that depend on the sourceFactory being set (not null) are ignored.

The setters for certain options do null checks on the sourceFactory, which doesn't seem to get set until generateSource() is later called.
Versions previous to 1.0 final (all milestone releases) do not have this problem.

With versions 1.0+, all SourceGenerator options that depend on the sourceFactory being set (not null) are ignored.

The setters for certain options do null checks on the sourceFactory, which doesn't seem to get set until generateSource() is later called.
Assignee Ralf Joachim [ rjoachim ]
Ralf Joachim made changes -
Assignee Ralf Joachim [ rjoachim ]
Ralf Joachim made changes -
Fix Version/s 1.0.2 [ 12660 ]
Werner Guttmann made changes -
Assignee Ralf Joachim [ rjoachim ] Werner Guttmann [ wguttmn ]
Hide
Permalink
Werner Guttmann added a comment -

Improved patch, dealing with an 'oddity' as introduced by the patch that added support for Java 5 generics. Speaking of which, after running the CTF test suites against this accumulative patch, I noted that the regression test suite finishes with 3 errors only .. .

Show
Werner Guttmann added a comment - Improved patch, dealing with an 'oddity' as introduced by the patch that added support for Java 5 generics. Speaking of which, after running the CTF test suites against this accumulative patch, I noted that the regression test suite finishes with 3 errors only .. .
Werner Guttmann made changes -
Attachment patch.c1477.20060802.txt [ 21996 ]
Werner Guttmann made changes -
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Werner Guttmann made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Jason Boutwell
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: