castor
  1. castor
  2. CASTOR-1412

remove dependency to adaptx from the documentation build step

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: None
    • Component/s: General
    • Labels:
      None
    • Number of attachments :
      2

      Description

      Until now the "ant doc" build step needed the adaptx and xerces libraries to transform the XML documentation into HTML pages.
      In order to remove this dependencies we should replace the JakartaAntAdapter XSLT processor of Adaptx by the standard Java 1.4 XSLT processor.
      The attached patch switches the build.xml file to this XSLT processor and modifies the XML documentation source to be compatible to it.

      1. castor-1412-buildscript.patch
        1 kB
        Martin Fuchs
      2. castor-xsl-doc.patch
        3 kB
        Martin Fuchs

        Activity

        Hide
        Werner Guttmann added a comment -

        I assume that we don't need any new JARs or similar as everything is part of the JDK/JRE already, rigt ?

        Show
        Werner Guttmann added a comment - I assume that we don't need any new JARs or similar as everything is part of the JDK/JRE already, rigt ?
        Hide
        Martin Fuchs added a comment -

        Yes, all you need is a JDK version >= 1.4. Then the "ant doc" command works without any predefined CLASSPATH - you even don't need to use the build.bat/sh script any more.

        Show
        Martin Fuchs added a comment - Yes, all you need is a JDK version >= 1.4. Then the "ant doc" command works without any predefined CLASSPATH - you even don't need to use the build.bat/sh script any more.
        Hide
        Werner Guttmann added a comment -

        Martin, do we know what other dependencies we have towards AdaptX, not that we have removed it in one place ?

        Show
        Werner Guttmann added a comment - Martin, do we know what other dependencies we have towards AdaptX, not that we have removed it in one place ?
        Hide
        Martin Fuchs added a comment -

        I am not sure. You know the project much better than me.
        Ralf, do you have any further comments on this? What exactly is used from adaptx for the test framework?

        Show
        Martin Fuchs added a comment - I am not sure. You know the project much better than me. Ralf, do you have any further comments on this? What exactly is used from adaptx for the test framework?
        Hide
        Ralf Joachim added a comment -

        I also do not know more on this but I'm have tried to remove adaptx.jar from classpath and that should me compile time dependencies in examples and xml tests framework Having said that there may be additional runtime dependecies that I'm not aware off.

        Show
        Ralf Joachim added a comment - I also do not know more on this but I'm have tried to remove adaptx.jar from classpath and that should me compile time dependencies in examples and xml tests framework Having said that there may be additional runtime dependecies that I'm not aware off.
        Hide
        Werner Guttmann added a comment -

        Martin, any idea why I get the following exception when executing the 'build doc' taks from a command line under Windows XP, JDK 1.4.2_08 ?

        C:\workspace\castor101\src\build.xml:547: java.lang.ClassNotFoundException: org.
        apache.tools.ant.taskdefs.optional.TraXLiaison

        Show
        Werner Guttmann added a comment - Martin, any idea why I get the following exception when executing the 'build doc' taks from a command line under Windows XP, JDK 1.4.2_08 ? C:\workspace\castor101\src\build.xml:547: java.lang.ClassNotFoundException: org. apache.tools.ant.taskdefs.optional.TraXLiaison
        Hide
        Martin Fuchs added a comment -

        Sorry, my fault: We need one additional ANT JAR file with the TRAX transformation code. I used an external ANT installation in my ANT_HOME environment variable. That way I didn't see the error you mentioned.
        The attached patch inserts the new JAR into build.bat ant build.sh. I will also commit the new ant-1.6-trax.jar file in the lib directory.

        Show
        Martin Fuchs added a comment - Sorry, my fault: We need one additional ANT JAR file with the TRAX transformation code. I used an external ANT installation in my ANT_HOME environment variable. That way I didn't see the error you mentioned. The attached patch inserts the new JAR into build.bat ant build.sh. I will also commit the new ant-1.6-trax.jar file in the lib directory.
        Hide
        Martin Fuchs added a comment -

        Just committed the missing file and added it to the build scripts.

        Show
        Martin Fuchs added a comment - Just committed the missing file and added it to the build scripts.
        Hide
        Werner Guttmann added a comment -

        Thanks.

        Show
        Werner Guttmann added a comment - Thanks.

          People

          • Assignee:
            Martin Fuchs
            Reporter:
            Martin Fuchs
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: