castor

Use molder.getLockEngine() instead of passing around LockEngine everywhere

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0
  • Fix Version/s: 1.0.1
  • Component/s: JDO
  • Labels:
    None
  • Number of attachments :
    1

Description

Subject says it all.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ralf Joachim added a comment -

Final patch for review.

Show
Ralf Joachim added a comment - Final patch for review.
Hide
Permalink
Werner Guttmann added a comment -

Looks good. I hope, though, that simplifying the usge of PersistenceInfo(Group) will not carry any repercussions ... . And as discussed yesterday, I believe that changing the method signatures of e.g. all the create() methods on TrnsactionContext, ClassMolder, RelationResolvers, etc. to not pass around Object[] for identities and field values separately (and switching to using ProposedEntity instead) will bring the same benefits in terms of code simplification.

Show
Werner Guttmann added a comment - Looks good. I hope, though, that simplifying the usge of PersistenceInfo(Group) will not carry any repercussions ... . And as discussed yesterday, I believe that changing the method signatures of e.g. all the create() methods on TrnsactionContext, ClassMolder, RelationResolvers, etc. to not pass around Object[] for identities and field values separately (and switching to using ProposedEntity instead) will bring the same benefits in terms of code simplification.

People

  • Assignee:
    Ralf Joachim
    Reporter:
    Ralf Joachim
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: