castor
  1. castor
  2. CASTOR-1393

Compiler warnings: 103 unnecessary casts

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.1
    • Component/s: General
    • Labels:
      None
    • Number of attachments :
      2

      Description

      When building castor under eclipse, 103 unnecessary casrs are reported. This can be easily be fixed by applying a standard rfactoring.

      1. patch-C1393-20060413-02.txt
        65 kB
        Ralf Joachim
      2. unnecessary-casts-patch.txt
        69 kB
        Henk van Voorthujsen

        Issue Links

          Activity

          Hide
          Werner Guttmann added a comment -

          Henk, mind providing us with a patch .. .

          Show
          Werner Guttmann added a comment - Henk, mind providing us with a patch .. .
          Hide
          Henk van Voorthujsen added a comment -

          This patch removes all unnecessary casts

          Show
          Henk van Voorthujsen added a comment - This patch removes all unnecessary casts
          Hide
          Ralf Joachim added a comment -

          Greate work as far as I can tell after a first look at the attached patch.

          Show
          Ralf Joachim added a comment - Greate work as far as I can tell after a first look at the attached patch.
          Hide
          Ralf Joachim added a comment -

          Removed following file from the patch:

          • .project
          • .checkstyle
          • .classpath
          • .externalToolBuilder
          • src/main/org/exolab/castor/mapping/xml/ClassMappingDescriptor.java

          Successfully executed test suites of XML and JDO and added release-notes and so on.

          Will commit ASAP.

          Show
          Ralf Joachim added a comment - Removed following file from the patch: .project .checkstyle .classpath .externalToolBuilder src/main/org/exolab/castor/mapping/xml/ClassMappingDescriptor.java Successfully executed test suites of XML and JDO and added release-notes and so on. Will commit ASAP.
          Hide
          Petteri Räty added a comment -

          You removed some needed cast that were done for http://jira.codehaus.org/browse/CASTOR-1086
          I opened http://jira.codehaus.org/browse/CASTOR-2008 for this.

          Show
          Petteri Räty added a comment - You removed some needed cast that were done for http://jira.codehaus.org/browse/CASTOR-1086 I opened http://jira.codehaus.org/browse/CASTOR-2008 for this.

            People

            • Assignee:
              Ralf Joachim
              Reporter:
              Henk van Voorthujsen
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: