castor

Incorrect java code generated when choice has long and string

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.9.7
  • Fix Version/s: 1.0.4
  • Component/s: XML code generator
  • Labels:
    None
  • Environment:
    Most
  • Number of attachments :
    2

Description

Incorrect java code generated, well maybe should issue an error, with this fragment

<xs:element name="UniqueID">
<xs:complexType>
<xs:choice>
<xs:element name="OID" type="xs:long"/>
<xs:element name="Name">
<xs:annotation>
<xs:documentation>Only currently supported for locating to topics</xs:documentation>
</xs:annotation>
<xs:simpleType>
<xs:restriction base="xs:string">
<xs:maxLength value="255"/>
</xs:restriction>
</xs:simpleType>
</xs:element>
</xs:choice>
</xs:complexType>

generates ...

/**

  • Sets the value of field 'name'. The field 'name' has the
  • following description: Only currently supported for locating
  • to topics
  • @param name the value of field 'name'.
    */
    public void setName(java.lang.String name)
    { this._name = name; this._choiceValue = name; }

    //-- void setName(java.lang.String)

/**

  • Sets the value of field 'OID'.
  • @param OID the value of field 'OID'.
    */
    public void setOID(long OID)
    { this._OID = OID; this._choiceValue = OID; this._has_OID = true; }

    //-- void setOID(long)

which fails trying to set choiceValue (Object) to a long ...
C:\svn-migrate\workspace\XPL_ALL\XPL_EJB\target\castor\src\com\syntegra\sbs\bg\x
pl\persistence\auto\UniqueID.java:196: incompatible types
found : long
required: java.lang.Object
this._choiceValue = OID;
^

This works on 0.9.5.2

  1. XML File
    castor-1335.xml
    02/Oct/06 4:10 AM
    4 kB
    Martin West
  2. Text File
    patch.c1335.20060912.txt
    12/Sep/06 9:57 AM
    2 kB
    Werner Guttmann

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. CASTOR-1568 When I try to generate the classes, the source generator simply hangs.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Sub-task - The sub-task of the issue CASTOR-1602 Add new test case type to read schema only

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Werner Guttmann added a comment -

What does the source code generated with 0.9.5.2 actually look like for setOID() method ?

Show
Werner Guttmann added a comment - What does the source code generated with 0.9.5.2 actually look like for setOID() method ?
Hide
Permalink
Werner Guttmann added a comment -

Martin, are you in a position to attach a complete (albeit minimal) XML schema and a sample XML document that one could to unmarshal against the sources as generated from the XML schema ? On the one hand, I'd like to improve the quality of Castor XML's test suite (CTF), on the other hand I'd like to make sure that future patches/refactorings don't break existing code (as unfortunately happeneed in this area several times).

Show
Werner Guttmann added a comment - Martin, are you in a position to attach a complete (albeit minimal) XML schema and a sample XML document that one could to unmarshal against the sources as generated from the XML schema ? On the one hand, I'd like to improve the quality of Castor XML's test suite (CTF), on the other hand I'd like to make sure that future patches/refactorings don't break existing code (as unfortunately happeneed in this area several times).
Hide
Permalink
Werner Guttmann added a comment -

Initail and final patch. Will commit after I have received fully working XML schema and sample XML .. .

Show
Werner Guttmann added a comment - Initail and final patch. Will commit after I have received fully working XML schema and sample XML .. .
Hide
Permalink
Martin West added a comment -

Will try, Its a few months ago since I filed this issue.

Show
Martin West added a comment - Will try, Its a few months ago since I filed this issue.
Hide
Permalink
Werner Guttmann added a comment -

I know ... , but I think a bit of a payback for a patch should not be that hard .. .

Show
Werner Guttmann added a comment - I know ... , but I think a bit of a payback for a patch should not be that hard .. .
Hide
Permalink
Martin West added a comment -

Have emailed the current version of the xsd file and the generated code.

Show
Martin West added a comment - Have emailed the current version of the xsd file and the generated code.
Hide
Permalink
Werner Guttmann added a comment -

Martin, as discussed by email, I'd still need a sample XML document to use for unmarshalling. Pretty please !

Show
Werner Guttmann added a comment - Martin, as discussed by email, I'd still need a sample XML document to use for unmarshalling. Pretty please !
Hide
Permalink
Werner Guttmann added a comment -

Martin, sorry for bothering you again, but as I have got a new dependency on this issue, can you please help me out with my request ?

Show
Werner Guttmann added a comment - Martin, sorry for bothering you again, but as I have got a new dependency on this issue, can you please help me out with my request ?
Hide
Permalink
Werner Guttmann added a comment -

Martin, I'd appreciate if you could attach the sample XML document to CASTOR-1598.

Show
Werner Guttmann added a comment - Martin, I'd appreciate if you could attach the sample XML document to CASTOR-1598 .
Hide
Permalink
Werner Guttmann added a comment -

Martin, the XML instance you sent does not match the XML schema for BusGovContent content. Is this on intention ?

Show
Werner Guttmann added a comment - Martin, the XML instance you sent does not match the XML schema for BusGovContent content. Is this on intention ?
Hide
Permalink
Martin West added a comment -

Not exactly, for some reason when I tried to get the file out of the email I sent you it came out zero length and this was a guess as to which file I sent, the algorythm I used was the latest testfile

Show
Martin West added a comment - Not exactly, for some reason when I tried to get the file out of the email I sent you it came out zero length and this was a guess as to which file I sent, the algorythm I used was the latest testfile
Hide
Permalink
Edward Kuns added a comment -

Martin, would it be OK if we use the schema you EMailed Werner as a unit test for Castor? It's a very large schema that exercises a lot of features, so it's a great candidate to be used as a "source generator test case".

Show
Edward Kuns added a comment - Martin, would it be OK if we use the schema you EMailed Werner as a unit test for Castor? It's a very large schema that exercises a lot of features, so it's a great candidate to be used as a "source generator test case".
Hide
Permalink
Martin West added a comment -

I dont see why you shouldnt.

Show
Martin West added a comment - I dont see why you shouldnt.
Hide
Permalink
Edward Kuns added a comment -

Thanks.

Show
Edward Kuns added a comment - Thanks.

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Martin West
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
30m
Original Estimate - 30 minutes Original Estimate - 30 minutes
Remaining:
30m
Time Spent - 1 hour Remaining Estimate - 30 minutes
Logged:
1h
Time Spent - 1 hour Remaining Estimate - 30 minutes