castor

COUNT doesn't work for Polymorphism

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 0.9.9 M2
  • Fix Version/s: 0.9.9.1
  • Component/s: JDO
  • Labels:
    None
  • Environment:
    MySQL 4.1.11
  • Testcase included:
    yes
  • Number of attachments :
    9

Description

jdo.test.Plan extends from jdo.test.ShareItem, when executing:
(1) SELECT p FROM jdo.test.Plan p WHERE p.state = $1
everything is good. But when try this:
(2) SELECT count(p.id) FROM jdo.test.Plan p WHERE p.state = $1
the exception will be thrown out:
java.sql.SQLException: Unknown table 'shareitem' in where clause

Statement (1) is excuted by SQLEngine, while (2) by SimpleQueryExecutor. SimpleQueryExecutor DOES resolve and field correctly, but forgets to join the parent table.

  1. File
    create.sql
    01/Nov/05 4:00 AM
    0.5 kB
    Sean
  2. XML File
    jdo-conf.xml
    01/Nov/05 4:00 AM
    0.5 kB
    Sean
  3. XML File
    mapping.xml
    01/Nov/05 4:00 AM
    0.7 kB
    Sean
  4. Text File
    patch.20051103.txt
    03/Nov/05 5:04 AM
    6 kB
    Werner Guttmann
  5. Text File
    patch.20051104.txt
    04/Nov/05 3:47 PM
    4 kB
    Werner Guttmann
  6. Text File
    patch.main.20051103.txt
    03/Nov/05 5:08 AM
    1 kB
    Werner Guttmann
  7. Java Source File
    Plan.java
    01/Nov/05 4:01 AM
    0.2 kB
    Sean
  8. Java Source File
    ShareItem.java
    01/Nov/05 4:01 AM
    0.6 kB
    Sean
  9. Java Source File
    TestTemplate.java
    01/Nov/05 4:01 AM
    2 kB
    Sean

Issue Links

depends upon

New Feature - A new feature of the product, which has yet to be developed. CASTOR-1254 Support DISTINCT inside COUNT clause

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Werner Guttmann added a comment -

Thanks, Sean. I'll look into this later on. i'd appreciate if you could attach a patch file (next time) following the bug submission guidelines at http://castor.codehaus.org/how-to-submit-a-bug.html.

Show
Werner Guttmann added a comment - Thanks, Sean. I'll look into this later on. i'd appreciate if you could attach a patch file (next time) following the bug submission guidelines at http://castor.codehaus.org/how-to-submit-a-bug.html .
Hide
Permalink
Werner Guttmann added a comment -

Unified patch for Sean's contribution.

Show
Werner Guttmann added a comment - Unified patch for Sean's contribution.
Hide
Permalink
Werner Guttmann added a comment -

Initial patch, adding code to ParseTreeWalker.addSelectFromJoins() to deal with extend relations. After applying this patch, all 53 CTF tests still complete successfully .. .

Show
Werner Guttmann added a comment - Initial patch, adding code to ParseTreeWalker.addSelectFromJoins() to deal with extend relations. After applying this patch, all 53 CTF tests still complete successfully .. .
Hide
Permalink
Werner Guttmann added a comment -

Sean, could you apply this 'little' patch and come back to me with feedback ?

Show
Werner Guttmann added a comment - Sean, could you apply this 'little' patch and come back to me with feedback ?
Hide
Permalink
Sean added a comment -

Werner, the patch works well for my case. Thanks for effort.

Show
Sean added a comment - Werner, the patch works well for my case. Thanks for effort.
Hide
Permalink
Werner Guttmann added a comment -

Thanks, Sean. I'll commit the patch once I have added some new test methods to src/tests/jdo/OQLTests.java to test this feature properly.

Show
Werner Guttmann added a comment - Thanks, Sean. I'll commit the patch once I have added some new test methods to src/tests/jdo/OQLTests.java to test this feature properly.
Hide
Permalink
Werner Guttmann added a comment -

Will integrate the test case provided with the CTF suite once CASTOR-1254 has been committed (as I don't really fancy duplicating a lot of work).

Show
Werner Guttmann added a comment - Will integrate the test case provided with the CTF suite once CASTOR-1254 has been committed (as I don't really fancy duplicating a lot of work).
Hide
Permalink
Werner Guttmann added a comment -

Proposed (final) patch, incl. the changes to src/tests/jdo/OqlTestsjava.

Show
Werner Guttmann added a comment - Proposed (final) patch, incl. the changes to src/tests/jdo/OqlTestsjava.

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Sean
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: