castor

Database.getIdentity(Object) should be able to resolve identity without relying on the object having been loaded from the database

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.9.9
  • Fix Version/s: 0.9.9.1
  • Component/s: JDO
  • Labels:
    None
  • Number of attachments :
    2

Description

Currently, Database.getIdentity() returns null if the object has not been loaded in the same transaction.

Consider the following scenario:

  • An object has been loaded from the database in a previous transaction
  • The object hs been marshaled to XML and sent to a client app
  • the client marks the object for removal and sends it back
  • The server unmarshalls the object in a new transaction- this gives a new instance
  • since remove() is also restricted to within transactions, i need to reload the original.
  • the obvious way to do that is with the newly received object's identity
  1. Text File
    patch-C1239-20051108.txt
    08/Nov/05 4:32 AM
    8 kB
    Ralf Joachim
  2. Text File
    patch-C1239-20051110.txt
    10/Nov/05 9:48 AM
    9 kB
    Ralf Joachim

Activity

Ascending order - Click to sort in descending order
Ralf Joachim made changes -
Field Original Value New Value
Assignee Ralf Joachim [ rjoachim ]
Hide
Permalink
Ralf Joachim added a comment -

Refactor org.exolab.castor.jdo.Utils to org.castor.jdo.util.JDOUtils and declare Utils as deprecated.
Add static closeDatabase() utility method.
Add static getIdentity() utility method.

The same code can be used to allow Database.getIdentity() to also return identity of objects that are not in the current transaction as this will be the more frequently usecase.

Show
Ralf Joachim added a comment - Refactor org.exolab.castor.jdo.Utils to org.castor.jdo.util.JDOUtils and declare Utils as deprecated. Add static closeDatabase() utility method. Add static getIdentity() utility method. The same code can be used to allow Database.getIdentity() to also return identity of objects that are not in the current transaction as this will be the more frequently usecase.
Ralf Joachim made changes -
Attachment patch-C1239-20051108.txt [ 17450 ]
Hide
Permalink
Werner Guttmann added a comment -

Let's go ahead and commit this code. Maybe you could find some time to make the comments in closeDatabase() a bit more readable ? Somehow this seems to have been copied from somewhere ..

Show
Werner Guttmann added a comment - Let's go ahead and commit this code. Maybe you could find some time to make the comments in closeDatabase() a bit more readable ? Somehow this seems to have been copied from somewhere ..
Ralf Joachim made changes -
Component/s JDO [ 11331 ]
Description Currently, Database.getIdentity() returns null if the object has not been loaded in the same transaction.

Consider the following scenario:

- An object has been loaded from the database in a previous transaction
- The object hs been marshaled to XML and sent to a client app
- the client marks the object for removal and sends it back
- The server unmarshalls the object in a new transaction- this gives a new instance
- since remove() is also restricted to within transactions, i need to reload the original.
- the obvious way to do that is with the newly received object's identity

 Currently, Database.getIdentity() returns null if the object has not been loaded in the same transaction.

Consider the following scenario:

- An object has been loaded from the database in a previous transaction
- The object hs been marshaled to XML and sent to a client app
- the client marks the object for removal and sends it back
- The server unmarshalls the object in a new transaction- this gives a new instance
- since remove() is also restricted to within transactions, i need to reload the original.
- the obvious way to do that is with the newly received object's identity
Environment
Fix Version/s 0.9.9.1 [ 12055 ]
Ralf Joachim made changes -
Status Open [ 1 ] In Progress [ 3 ]
Hide
Permalink
Ralf Joachim added a comment -

Final patch which improves Database.getIdentity() instead of adding JDOUtils.getIdentity() helper method. The other changes contained in the previous patch have been resolved with CASTOR-1259 and CASTOR-1260.

Show
Ralf Joachim added a comment - Final patch which improves Database.getIdentity() instead of adding JDOUtils.getIdentity() helper method. The other changes contained in the previous patch have been resolved with CASTOR-1259 and CASTOR-1260 .
Ralf Joachim made changes -
Attachment patch-C1239-20051110.txt [ 17502 ]
Ralf Joachim made changes -
Status In Progress [ 3 ] Open [ 1 ]
Ralf Joachim made changes -
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Ralf Joachim made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Ralf Joachim
    Reporter:
    Henk van Voorthujsen
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: