jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
Signup
castor
  • castor
  • CASTOR-1171

SQLTypes cleanup

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 0.9.7
  • Fix Version/s: 1.0 M1
  • Component/s: JDO queries
  • Labels:
    None
  • Number of attachments :
    2

Description

I've cleaned up SQLTypes and one of the things I've done is to remove TypeConvertorInfo as it was just an overhead.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    patch_sqltypes_1.txt
    10/Jul/05 1:17 PM
    65 kB
    Stein M. Hugubakken
  2. Text File
    patch-C1171-20051124.txt
    25/Nov/05 12:11 AM
    141 kB
    Ralf Joachim

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Gregory Block added a comment - 15/Jul/05 6:00 AM

On first glance? I like it. I do wonder, however, if this kind of information is duplicated anywhere else in the codebase; is there any way that type conversion on the XML side can be shared with type conversion on the SQL side?

There must be some way to allow us to support the same field handlers as those used on the XML side. Is there a way for us to unify our handling to a common set of code, here? Does anyone on the XML side have an idea/opinion?

As for sqlToJavaName: If you don't see it being used, I don't see any problem with jettisoning the code; it's there in the repository if needed.

Show
Gregory Block added a comment - 15/Jul/05 6:00 AM On first glance? I like it. I do wonder, however, if this kind of information is duplicated anywhere else in the codebase; is there any way that type conversion on the XML side can be shared with type conversion on the SQL side? There must be some way to allow us to support the same field handlers as those used on the XML side. Is there a way for us to unify our handling to a common set of code, here? Does anyone on the XML side have an idea/opinion? As for sqlToJavaName: If you don't see it being used, I don't see any problem with jettisoning the code; it's there in the repository if needed.
Hide
Permalink
Ralf Joachim added a comment - 15/Jul/05 4:53 PM

I like that patch too and also think we should remove unused methods. Searching a commons at type conversion between JDO and XML should be handled at another issue. IMO go ahead Stein.

Show
Ralf Joachim added a comment - 15/Jul/05 4:53 PM I like that patch too and also think we should remove unused methods. Searching a commons at type conversion between JDO and XML should be handled at another issue. IMO go ahead Stein.
Hide
Permalink
Werner Guttmann added a comment - 25/Jul/05 3:36 AM

Looks good to me. And lets's make sure we remove anything that isn't used as much as we can. And +1 for creating a new issue wrt to the JDO/XML type handling commonalities. Stein, can I assume that you will be checkstyling your patch before committing ?

Show
Werner Guttmann added a comment - 25/Jul/05 3:36 AM Looks good to me. And lets's make sure we remove anything that isn't used as much as we can. And +1 for creating a new issue wrt to the JDO/XML type handling commonalities. Stein, can I assume that you will be checkstyling your patch before committing ?
Hide
Permalink
Werner Guttmann added a comment - 04/Aug/05 9:06 AM

Stein, can you please re-attach your patch, as it can not easily be allied against current CVS any more (as quite a lot of things have changed). Once you've done so, I'll remove the methods as discussed above, checkstyle and commit.

Show
Werner Guttmann added a comment - 04/Aug/05 9:06 AM Stein, can you please re-attach your patch, as it can not easily be allied against current CVS any more (as quite a lot of things have changed). Once you've done so, I'll remove the methods as discussed above, checkstyle and commit.
Hide
Permalink
Werner Guttmann added a comment - 20/Oct/05 9:22 AM

Stein, any chances of providing us with a new patch ?

Show
Werner Guttmann added a comment - 20/Oct/05 9:22 AM Stein, any chances of providing us with a new patch ?
Hide
Permalink
Ralf Joachim added a comment - 25/Nov/05 12:11 AM

Final patch of refactoring for review. I got a bit further by separating SQLTypeInfos and SQLTypeConverters.

Show
Ralf Joachim added a comment - 25/Nov/05 12:11 AM Final patch of refactoring for review. I got a bit further by separating SQLTypeInfos and SQLTypeConverters.

People

  • Assignee:
    Ralf Joachim
    Reporter:
    Stein M. Hugubakken
Vote (0)
Watch (0)

Dates

  • Created:
    10/Jul/05 1:17 PM
    Updated:
    08/Feb/06 1:41 PM
    Resolved:
    25/Nov/05 5:37 PM
  • Atlassian JIRA (v5.2.7#850-sha1:b2af0c8)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.