castor

Refactor CTF-JDO tests into subdirectories (part 2)

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.9.6
  • Fix Version/s: 0.9.9 M1
  • Component/s: JDO
  • Labels:
    None
  • Number of attachments :
    8

Description

Move test cases, test objects and mappings into subdirectories (e.g. jdo.tx0x for tests TC01, TC02 ...). Tests with lots of classes involved will get their own subdirectory. Also test numbers will change and the current grouping will be dropped as it did not fit also in the past.

The old logging stream will also be replaced with commons-logging.

I'll intend a second refactoring that will enable running tests from ant or within eclipse. A third refactoring should target to execute the sql scripts throughCTF-JDO test framework like: 'test -setup castor.mysql'. That will allow to put also the scripts into the subdirectories.

  1. File
    Castor test checks.plugin config
    02/Jun/05 4:54 PM
    14 kB
    Ralf Joachim
  2. Text File
    patch.20050601.txt
    01/Jun/05 3:42 AM
    419 kB
    Werner Guttmann
  3. Text File
    patch.20050601-02.txt
    01/Jun/05 5:05 AM
    402 kB
    Werner Guttmann
  4. Text File
    patch.20050622.txt
    22/Jun/05 7:27 AM
    404 kB
    Werner Guttmann
  5. Text File
    patch.20050704.txt
    04/Jul/05 4:56 AM
    490 kB
    Werner Guttmann
  6. Text File
    patch-C1110.20050530.txt
    30/May/05 5:09 AM
    2 kB
    Ralf Joachim
  7. Text File
    patch-C1110-20050602.txt
    02/Jun/05 4:49 PM
    401 kB
    Ralf Joachim
  8. Text File
    patch-C1110-20050702.txt
    01/Jul/05 6:50 PM
    487 kB
    Ralf Joachim

Issue Links

depends upon

Improvement - An improvement or enhancement to an existing feature or task. CASTOR-1063 Refactor CTF-JDO tests into subdirectories (part 1)

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is depended upon by

Improvement - An improvement or enhancement to an existing feature or task. CASTOR-1164 Refactor CTF-JDO tests into subdirectories (part 3)

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. CASTOR-518 Table aliases not used in HSQLDB OQL-SQL generator class

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. CASTOR-622 aliases for self-join tables are incorrect

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Ralf Joachim made changes -
Field Original Value New Value
Link This issue depends upon CASTOR-1063 [ CASTOR-1063 ]
Ralf Joachim made changes -
Link This issue is depended upon by CASTOR-1052 [ CASTOR-1052 ]
Hide
Permalink
Ralf Joachim added a comment -

Patch that shows by comment which tests are intended to go into tc2x subdirectory.

Show
Ralf Joachim added a comment - Patch that shows by comment which tests are intended to go into tc2x subdirectory.
Ralf Joachim made changes -
Attachment patch-C1110.20050530.txt [ 15442 ]
Hide
Permalink
Werner Guttmann added a comment -

Initail patch fro tc2x.

  • Files have been moved and renamed.
  • Mapping has been moved.

To-Dos:

  • logging consistency.
  • println()s
Show
Werner Guttmann added a comment - Initail patch fro tc2x. Files have been moved and renamed. Mapping has been moved. To-Dos: logging consistency. println()s
Werner Guttmann made changes -
Attachment patch.20050601.txt [ 15473 ]
Hide
Permalink
Werner Guttmann added a comment -

Updated patch (with logging changed to Jakarta Common Logging), but still no codestyle .. .

Show
Werner Guttmann added a comment - Updated patch (with logging changed to Jakarta Common Logging), but still no codestyle .. .
Werner Guttmann made changes -
Attachment patch.20050601-02.txt [ 15475 ]
Hide
Permalink
Ralf Joachim added a comment -

Patch looks very good so far. I only did some small changes to test.xml and tc2x.mapping.xml as well as moved jdo.TestKeyGenObject to ctf.jdo.tc2x.KeyGenObject.

One additional improvement of the logging could be to make the messages of log.error(..) and fail(..) equal. Especialy the 'Error:' contained in the log.error(..) messages are not needed any more.

Show
Ralf Joachim added a comment - Patch looks very good so far. I only did some small changes to test.xml and tc2x.mapping.xml as well as moved jdo.TestKeyGenObject to ctf.jdo.tc2x.KeyGenObject. One additional improvement of the logging could be to make the messages of log.error(..) and fail(..) equal. Especialy the 'Error:' contained in the log.error(..) messages are not needed any more.
Ralf Joachim made changes -
Attachment patch-C1110-20050602.txt [ 15483 ]
Hide
Permalink
Ralf Joachim added a comment -

To omit any confusion about checkstyle rules I also attached the plugin config I used for checking tests.

Show
Ralf Joachim added a comment - To omit any confusion about checkstyle rules I also attached the plugin config I used for checking tests.
Ralf Joachim made changes -
Attachment Castor test checks.plugin config [ 15484 ]
Hide
Permalink
Werner Guttmann added a comment -

As dicussed elesewhere, I think that the TestDependent* classes (and dependencies) should be moved to a separate (new) tcXY package, to allow for more tests to be added in teh key gen area.

Show
Werner Guttmann added a comment - As dicussed elesewhere, I think that the TestDependent* classes (and dependencies) should be moved to a separate (new) tcXY package, to allow for more tests to be added in teh key gen area.
Hide
Permalink
Werner Guttmann added a comment -

Ralf, let's commit this change, and let's think about the other issues mentioned as we encounter a need to do so.

Show
Werner Guttmann added a comment - Ralf, let's commit this change, and let's think about the other issues mentioned as we encounter a need to do so.
Hide
Permalink
Ralf Joachim added a comment -

I would prefer to get all tasks finished before commiting as only checkstyle is missing. If you like to split them into 2 packages that would be the minimum to do before the commit.

Show
Ralf Joachim added a comment - I would prefer to get all tasks finished before commiting as only checkstyle is missing. If you like to split them into 2 packages that would be the minimum to do before the commit.
Hide
Permalink
Werner Guttmann added a comment -

Updated patch incl. checkstyled code artefacts only ...

Show
Werner Guttmann added a comment - Updated patch incl. checkstyled code artefacts only ...
Werner Guttmann made changes -
Attachment patch.20050622.txt [ 15714 ]
Hide
Permalink
Ralf Joachim added a comment -

Updated patch with some additionyl codestyling and renaming of tables. Patch has only be tested against hsql and mysql yet. At minimum it needs to be tested against oracle also.

Show
Ralf Joachim added a comment - Updated patch with some additionyl codestyling and renaming of tables. Patch has only be tested against hsql and mysql yet. At minimum it needs to be tested against oracle also.
Ralf Joachim made changes -
Attachment patch-C1110-20050702.txt [ 15792 ]
Hide
Permalink
Werner Guttmann added a comment -

Ralf, I'll try to cover postgreSQL early next week.

Show
Werner Guttmann added a comment - Ralf, I'll try to cover postgreSQL early next week.
Hide
Permalink
Werner Guttmann added a comment -

Updated new db2 category with required changes.

Show
Werner Guttmann added a comment - Updated new db2 category with required changes.
Werner Guttmann made changes -
Attachment patch.20050704.txt [ 15809 ]
Ralf Joachim made changes -
Status Open [ 1 ] In Progress [ 3 ]
Ralf Joachim made changes -
Link This issue is depended upon by CASTOR-1164 [ CASTOR-1164 ]
Ralf Joachim made changes -
Link This issue is depended upon by CASTOR-1052 [ CASTOR-1052 ]
Ralf Joachim made changes -
Status In Progress [ 3 ] Open [ 1 ]
Ralf Joachim made changes -
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Ralf Joachim made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Ralf Joachim made changes -
Link This issue is related to CASTOR-518 [ CASTOR-518 ]
Hide
Permalink
Ralf Joachim added a comment -

I resolved that problem while working on CASTOR-1110.

Show
Ralf Joachim added a comment - I resolved that problem while working on CASTOR-1110 .
Ralf Joachim made changes -
Link This issue is related to CASTOR-622 [ CASTOR-622 ]
Hide
Permalink
Ralf Joachim added a comment -

As far as I understand this problem it's more about a problem with table aliases then self reference relation. The problem with the table aliases has been resolved by me while working at CASTOR-1110.

Show
Ralf Joachim added a comment - As far as I understand this problem it's more about a problem with table aliases then self reference relation. The problem with the table aliases has been resolved by me while working at CASTOR-1110 .

People

  • Assignee:
    Ralf Joachim
    Reporter:
    Ralf Joachim
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
2w
Original Estimate - 2 weeks
Remaining:
2w
Remaining Estimate - 2 weeks
Logged:
Not Specified
Time Spent - Not Specified