castor

Castor JDO Identity key generator does not work with IBM DB2.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.9.6
  • Fix Version/s: 1.0 M4
  • Component/s: JDO
  • Labels:
    None
  • Number of attachments :
    2

Description

The Castor JDO 0.9.6 Identity key generator class "org.exolab.castor.jdo.drivers. IdentityKeyGenerator" does not work with IBM DB2 v6.

The current SQL statement used by inner class DB2Type is :

private class DB2Type extends AbstractType {
Object getValue(Connection conn, String tableName) throws PersistenceException

{ StringBuffer buf = new StringBuffer("SELECT IDENTITY_VAL_LOCAL() FROM "); buf.append(tableName).append(" FETCH FIRST ROW ONLY"); return getValue(buf.toString(), conn); }

}

However, this statement only seems to work with IBM UDB v7 and v8. It does not work with IBM DB2 v6.

The following SQL statement seems to work with IBM UDB and IBM DB2

private class DB2Type extends AbstractType {
Object getValue(Connection conn, String tableName) throws PersistenceException

{ StringBuffer buf = new StringBuffer("SELECT IDENTITY_VAL_LOCAL() FROM sysibm.sysdummy1"); return getValue(buf.toString(), conn); }

}

I suggest revising the SQL statement to the latter version. which works with UDB and DB2.

A patch file containing the revision is attached.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Werner Guttmann added a comment -

Tim, thanks for the patch. I'll look into this a.s.a.p.

Show
Werner Guttmann added a comment - Tim, thanks for the patch. I'll look into this a.s.a.p.
Hide
Permalink
Werner Guttmann added a comment -

Tim, one of the problems we (JDO committers) are currently is that none of us has access to DB2. Would you be willing to help me with a couple of small issues, e.g. trying to run the JDO CTF suite against DB2 based upon instructions I'd provide ?

Show
Werner Guttmann added a comment - Tim, one of the problems we (JDO committers) are currently is that none of us has access to DB2. Would you be willing to help me with a couple of small issues, e.g. trying to run the JDO CTF suite against DB2 based upon instructions I'd provide ?
Hide
Permalink
Tim Telcik added a comment -

Hello Werner,

I have limited access to IBM DB2 (on our mainframe), but should be able to come to some happy arrangement with our DBAs.

Please advise how to run your test suite and I'll do what I can.

Tim.

Show
Tim Telcik added a comment - Hello Werner, I have limited access to IBM DB2 (on our mainframe), but should be able to come to some happy arrangement with our DBAs. Please advise how to run your test suite and I'll do what I can. Tim.
Hide
Permalink
Werner Guttmann added a comment -

Here's a (hopefully) complete list of steps required to get there:

a) Download source distribution/obtain latest code form CVS repo.
b) build Castor by issueing build.sh/.bat jar
c) build CTF test suite, as per build jar.jdotests.

Before going about c), you'll have to create the following files:

1) db.xml, changing its configuration to reflect your DB2 requiremenst.
2) Create db2.sql (by e.g. copying one of the the files, and chnage things so that this script can be completetely executed on DB2).
3) Add a new category in src/tests/tests.xml for db2, by copying another category (e.g. mysql).

Let me know whether you need anymore help.

Show
Werner Guttmann added a comment - Here's a (hopefully) complete list of steps required to get there: a) Download source distribution/obtain latest code form CVS repo. b) build Castor by issueing build.sh/.bat jar c) build CTF test suite, as per build jar.jdotests. Before going about c), you'll have to create the following files: 1) db.xml, changing its configuration to reflect your DB2 requiremenst. 2) Create db2.sql (by e.g. copying one of the the files, and chnage things so that this script can be completetely executed on DB2). 3) Add a new category in src/tests/tests.xml for db2, by copying another category (e.g. mysql). Let me know whether you need anymore help.
Hide
Permalink
Werner Guttmann added a comment -

Forgot to add

d) Run the CTF tests for DB2 using test castor.db2, assuming that the category you added in src/tests/tests.xml is named 'db2'.

Show
Werner Guttmann added a comment - Forgot to add d) Run the CTF tests for DB2 using test castor.db2, assuming that the category you added in src/tests/tests.xml is named 'db2'.
Hide
Permalink
Werner Guttmann added a comment -

Tim, I am assigning this issue to be fixed for the 0.9.7 release in two weeks time. But I'd really need your help with this issue.

Show
Werner Guttmann added a comment - Tim, I am assigning this issue to be fixed for the 0.9.7 release in two weeks time. But I'd really need your help with this issue.
Hide
Permalink
Tim Telcik added a comment -

Hi Werner,

I may not be able to run the CTF to validate the DB2 Identity Key Gen fix before your scheduled 0.9.7 release.

Please proceed with your 0.9.7 rollout without the patch to this issue.

I will proceed on the basis the fix to the DB2 Identity key gen IS NOT included in the 0.9.7 rollout. We can however integrate the DB2 Identity key gen with our code base (eg. DB2IdentityKeyGenerator) and submit the tested patch at a later date.

Tim.

Show
Tim Telcik added a comment - Hi Werner, I may not be able to run the CTF to validate the DB2 Identity Key Gen fix before your scheduled 0.9.7 release. Please proceed with your 0.9.7 rollout without the patch to this issue. I will proceed on the basis the fix to the DB2 Identity key gen IS NOT included in the 0.9.7 rollout. We can however integrate the DB2 Identity key gen with our code base (eg. DB2IdentityKeyGenerator) and submit the tested patch at a later date. Tim.
Hide
Permalink
Werner Guttmann added a comment -

Sure, no problem. Whatever is convenient for you ....

Show
Werner Guttmann added a comment - Sure, no problem. Whatever is convenient for you ....
Hide
Permalink
Werner Guttmann added a comment -

Tim, any chances of getting this tested with your DB2 folks any time soon ?

Show
Werner Guttmann added a comment - Tim, any chances of getting this tested with your DB2 folks any time soon ?
Hide
Permalink
Werner Guttmann added a comment -

Re-assigning to 1.0.

Show
Werner Guttmann added a comment - Re-assigning to 1.0.
Hide
Permalink
Werner Guttmann added a comment -

Tim ?

Show
Werner Guttmann added a comment - Tim ?
Hide
Permalink
Werner Guttmann added a comment -

Maybe we should make this dependent on the DB2 version in use ?

Show
Werner Guttmann added a comment - Maybe we should make this dependent on the DB2 version in use ?
Hide
Permalink
Werner Guttmann added a comment -

Updated patch, incl. change log entries.

Show
Werner Guttmann added a comment - Updated patch, incl. change log entries.

People

  • Assignee:
    Werner Guttmann
    Reporter:
    Tim Telcik
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
20m
Original Estimate - 20 minutes
Remaining:
20m
Remaining Estimate - 20 minutes
Logged:
Not Specified
Time Spent - Not Specified