Cargo

cargo:start fails if internet is unavailable

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0.6
  • Fix Version/s: 1.1.0
  • Component/s: Core
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

Problem report

The following correct jboss-web.xml makes cargo fail if internet is unavailable (for example, unconfigured proxy).

<!DOCTYPE jboss-web PUBLIC "-//JBoss//DTD Web Application 4.2//EN" "http://www.jboss.org/j2ee/dtd/jboss-web_4_2.dtd">

<jboss-web>

 

    <class-loading java2ClassLoadingCompliance="false">

        <loader-repository>

            ${project.build.finalName}:loader=${project.build.finalName}.war

            <loader-repository-config>java2ParentDelegation=false</loader-repository-config>

        </loader-repository>

    </class-loading>

 

</jboss-web>

Stacktrace is:

[exec] Caused by: java.net.ConnectException: Connection refused: connect
     [exec] 	at java.net.PlainSocketImpl.socketConnect(Native Method)
     [exec] 	at java.net.PlainSocketImpl.doConnect(PlainSocketImpl.java:333)
     [exec] 	at java.net.PlainSocketImpl.connectToAddress(PlainSocketImpl.java:195)
     [exec] 	at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:182)
     [exec] 	at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:366)
     [exec] 	at java.net.Socket.connect(Socket.java:525)
     [exec] 	at java.net.Socket.connect(Socket.java:475)
     [exec] 	at sun.net.NetworkClient.doConnect(NetworkClient.java:163)
     [exec] 	at sun.net.www.http.HttpClient.openServer(HttpClient.java:394)
     [exec] 	at sun.net.www.http.HttpClient.openServer(HttpClient.java:529)
     [exec] 	at sun.net.www.http.HttpClient.<init>(HttpClient.java:233)
     [exec] 	at sun.net.www.http.HttpClient.New(HttpClient.java:306)
     [exec] 	at sun.net.www.http.HttpClient.New(HttpClient.java:323)
     [exec] 	at sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(HttpURLConnection.java:860)
     [exec] 	at sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:801)
     [exec] 	at sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:726)
     [exec] 	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1049)
     [exec] 	at java.net.URL.openStream(URL.java:1010)
     [exec] 	at org.codehaus.cargo.module.XmlEntityResolver.resolveEntity(XmlEntityResolver.java:99)
     [exec] 	at com.sun.org.apache.xerces.internal.util.EntityResolverWrapper.resolveEntity(EntityResolverWrapper.java:107)
     [exec] 	at com.sun.org.apache.xerces.internal.impl.XMLEntityManager.resolveEntityAsPerStax(XMLEntityManager.java:1018)
     [exec] 	at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$DTDDriver.dispatch(XMLDocumentScannerImpl.java:1192)
     [exec] 	at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$DTDDriver.next(XMLDocumentScannerImpl.java:1090)
     [exec] 	at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDriver.next(XMLDocumentScannerImpl.java:1003)
     [exec] 	at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:648)
     [exec] 	at com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:140)
     [exec] 	at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:511)
     [exec] 	at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:808)
     [exec] 	at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:737)
     [exec] 	at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:119)
     [exec] 	at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1205)
     [exec] 	at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:522)
     [exec] 	at org.jdom.input.SAXBuilder.build(SAXBuilder.java:453)
     [exec] 	at org.jdom.input.SAXBuilder.build(SAXBuilder.java:770)
     [exec] 	at org.codehaus.cargo.module.AbstractDescriptorIo.parseXml(AbstractDescriptorIo.java:129)
     [exec] 	at org.codehaus.cargo.module.AbstractDescriptorIo.parseXml(AbstractDescriptorIo.java:113)
     [exec] 	at org.codehaus.cargo.module.webapp.jboss.JBossWebXmlIo.parseJBossWebXml(JBossWebXmlIo.java:58)
     [exec] 	at org.codehaus.cargo.module.webapp.jboss.JBossWarArchive.parseJBossWebXml(JBossWarArchive.java:97)
     [exec] 	at org.codehaus.cargo.module.webapp.jboss.JBossWarArchive.<init>(JBossWarArchive.java:61)
     [exec] 	at org.codehaus.cargo.container.jboss.JBossWAR.<init>(JBossWAR.java:52)

Workaround

This jboss-web.xml works:

<!DOCTYPE jboss-web PUBLIC "-//JBoss//DTD Web Application 4.2//EN" "jboss-web_4_0.dtd">

<jboss-web>

 

    <class-loading java2ClassLoadingCompliance="false">

        <loader-repository>

            ${project.build.finalName}:loader=${project.build.finalName}.war

            <loader-repository-config>java2ParentDelegation=false</loader-repository-config>

        </loader-repository>

    </class-loading>

 

</jboss-web>

Recommended longterm fix

The method AbstractDescriptionIo:createDocumentBuilder(EntityResolver theEntityResolver) has a call to factory.setValidation(false);
This is not enough. You need to:

factory.setFeature("http://xml.org/sax/features/validation", false);
factory.setFeature("http://apache.org/xml/features/nonvalidating/load-dtd-grammar", false);
factory.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false);

Please see http://dequeue.blogspot.com/2008/12/completely-ignoring-dtd-with.html for inspiration.

Thanks!

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. CARGO-1019 cargo:deploy fails if internet is unavailable

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Savas Ali Tokmen added a comment -

Thank you for the detailed description and analysis.

In our DocumentMergerByXslt class, we have the following code:

// We don't know what the DTD of the document is, so we won't have a local
// copy - so we don't want to fail if we can't get it!

factory.setEntityResolver(new EntityResolver()
{
    public InputSource resolveEntity(String thePublicId,
        String theSystemId) throws SAXException
    {
        return new InputSource(new StringReader(""));
    }
});

Do you think this solution also works for this issue? I would personally prefer this one to setting parser-specific attributes.

Thank you

Show
Savas Ali Tokmen added a comment - Thank you for the detailed description and analysis. In our DocumentMergerByXslt class, we have the following code: // We don't know what the DTD of the document is, so we won't have a local // copy - so we don't want to fail if we can't get it! factory.setEntityResolver(new EntityResolver() { public InputSource resolveEntity(String thePublicId, String theSystemId) throws SAXException { return new InputSource(new StringReader("")); } }); Do you think this solution also works for this issue? I would personally prefer this one to setting parser-specific attributes. Thank you
Hide
Permalink
Savas Ali Tokmen added a comment -

Committed revision 2829, which might fix this issue.

Can you please try with Cargo 1.1.0-SNAPSHOT?

Show
Savas Ali Tokmen added a comment - Committed revision 2829, which might fix this issue. Can you please try with Cargo 1.1.0-SNAPSHOT?
Hide
Permalink
Johan Ferner added a comment - - edited

Thank you for this fast fix!
The problem is gone as it should when I looked at your code.
Just to clarify, I have rerun the build that failed with 1.0.6. It works fine with 1.1.0-SNAPSHOT.

Show
Johan Ferner added a comment - - edited Thank you for this fast fix! The problem is gone as it should when I looked at your code. Just to clarify, I have rerun the build that failed with 1.0.6. It works fine with 1.1.0-SNAPSHOT.
Hide
Permalink
Anders Hammar added a comment -

Ali, I'm assigning this to you as you committed the fix. I guess the ticket is ok to close as it has been verified?

Show
Anders Hammar added a comment - Ali, I'm assigning this to you as you committed the fix. I guess the ticket is ok to close as it has been verified?
Hide
Permalink
Savas Ali Tokmen added a comment -

Let's then close

Show
Savas Ali Tokmen added a comment - Let's then close

People

  • Assignee:
    Savas Ali Tokmen
    Reporter:
    Johan Ferner
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: