Cargo

Update documentation for "merge.xml" in uberwar goal

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.1.0
  • Component/s: Documentation
  • Labels:
    None
  • Complexity:
    Intermediate
  • Tested on JDKs:
    1.4, 5.0. 6.0
  • Number of attachments :
    1

Description

My merge file is like this 

<?xml version="1.0" encoding="UTF-8"?>
<uberwar>
  <wars>
    <war>com.tty.tragid:Tragid</war>
    <war>QuartersUI:QuartersUI</war>
  </wars>
  <webXml>
    <contextParams>
      <strategy name="ChooseByName">
        <default>
          <strategy name="Preserve"/>
        </default>
        <choice name="contextConfigLocation">
          <strategy name="NodeMerge">
            <context-param>
              <param-name>$left:/param-name</param-name>
              <param-value>$left:/param-value, $right:/param-value</param-value>
            </context-param>
          </strategy>
        </choice>
      </strategy>
    </contextParams>
  </webXml>
</uberwar>

I had a look at the source code and it seems to me that webXML node doesnt get processed at all, because the processing is happening in doMerge(...) which happens only for <merges/> nodes.

Is this a known issue? I am stuck with this issue and cannot use the uberwar goal because of this reason.

  1. XML File
    merge.xml
    14/Mar/11 6:05 AM
    1 kB
    Anton Khitrenovich

Issue Links

relates to

Improvement - An improvement or enhancement to an existing feature or task. CARGO-968 Remove redundant <default> tag from "uberwar" merge descriptor

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Open - The issue is open and ready for the assignee to start work on it.

Improvement - An improvement or enhancement to an existing feature or task. CARGO-969 Revisit <merge> nodes implementation in "uberwar" merge descriptor

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anton Khitrenovich added a comment -

I did some reverse engineering on that. It seems that merge of "web.xml" does not work as documented since mid-2007 (sic!). The functionality is implemented via special merge type with parameters. Sample merge descriptor is attached.

Show
Anton Khitrenovich added a comment - I did some reverse engineering on that. It seems that merge of "web.xml" does not work as documented since mid-2007 (sic!). The functionality is implemented via special merge type with parameters. Sample merge descriptor is attached.
Hide
Permalink
Vaishakh Nadgir added a comment -

Thanks for the merge.xml. Does this only work with 1.0.6-SNAPSHOT?
Can you provide a test case for this scenario and point me to the test case.

Show
Vaishakh Nadgir added a comment - Thanks for the merge.xml. Does this only work with 1.0.6-SNAPSHOT? Can you provide a test case for this scenario and point me to the test case.
Hide
Permalink
Anton Khitrenovich added a comment -

I checked it with Cargo 1.0.6, but it should work with earlier versions since 1.0 more or less (based on code history - did not test this).

BTW - Cargo 1.0.6 is a released version and it appears in Maven Central.
http://repo1.maven.org/maven2/org/codehaus/cargo/cargo-maven2-plugin/1.0.6/

Show
Anton Khitrenovich added a comment - I checked it with Cargo 1.0.6, but it should work with earlier versions since 1.0 more or less (based on code history - did not test this). BTW - Cargo 1.0.6 is a released version and it appears in Maven Central. http://repo1.maven.org/maven2/org/codehaus/cargo/cargo-maven2-plugin/1.0.6/
Hide
Permalink
Vaishakh Nadgir added a comment -

This works. However, it would be great to allow comma seperated (delimiter) values in the resulting web.xml for init-params like contextConfigLocation, etc... At the moment, the default delitmiter is white space.
I can provide the code for that if you like.

Also can you please update the documentation to reflect this change from using webXml to using merges with parameters for merging web.xml

Show
Vaishakh Nadgir added a comment - This works. However, it would be great to allow comma seperated (delimiter) values in the resulting web.xml for init-params like contextConfigLocation, etc... At the moment, the default delitmiter is white space. I can provide the code for that if you like. Also can you please update the documentation to reflect this change from using webXml to using merges with parameters for merging web.xml
Hide
Permalink
Savas Ali Tokmen added a comment -

I've changed the type to "documentation" and the fix version to "1.1.0" since it's the fix version for the documentation.

Who would like to update documenation?

Show
Savas Ali Tokmen added a comment - I've changed the type to "documentation" and the fix version to "1.1.0" since it's the fix version for the documentation. Who would like to update documenation?
Hide
Permalink
Anton Khitrenovich added a comment -

@Vaishakh:

At the moment, the delimiter is what you actually provide in your NodeMerge configuration.
For example, the following XML will result in comma-separated values:

<strategy name="NodeMerge">
  <context-param>
    <param-name>$left:param-name</param-name>
    <param-value>$left:param-value,$right:param-value</param-value>
  </context-param>
</strategy>
Show
Anton Khitrenovich added a comment - @Vaishakh: At the moment, the delimiter is what you actually provide in your NodeMerge configuration. For example, the following XML will result in comma-separated values: <strategy name="NodeMerge"> <context-param> <param-name>$left:param-name</param-name> <param-value>$left:param-value,$right:param-value</param-value> </context-param> </strategy>
Hide
Permalink
Anton Khitrenovich added a comment -

@Ali:

I'll do that, it is not a problem to update the documentation when we already know what the code actually supports. However, I'm not sure that for Cargo 1.1 we should leave the "web.xml" merge implementation as it is now - both from code and configuration point of view. Let me think about it a little bit (a day or two), and maybe I'll open another issue for refactoring

Show
Anton Khitrenovich added a comment - @Ali: I'll do that, it is not a problem to update the documentation when we already know what the code actually supports. However, I'm not sure that for Cargo 1.1 we should leave the "web.xml" merge implementation as it is now - both from code and configuration point of view. Let me think about it a little bit (a day or two), and maybe I'll open another issue for refactoring
Hide
Permalink
Anton Khitrenovich added a comment -

Updated the title to match actual work to be done.

Show
Anton Khitrenovich added a comment - Updated the title to match actual work to be done.
Hide
Permalink
Savas Ali Tokmen added a comment -

Hi Anton

Well, I will let you decide, then If you're unsure the dev mailing list is always here.

Thank you

Show
Savas Ali Tokmen added a comment - Hi Anton Well, I will let you decide, then If you're unsure the dev mailing list is always here. Thank you
Hide
Permalink
Savas Ali Tokmen added a comment -

So... Any progress?

Show
Savas Ali Tokmen added a comment - So... Any progress?
Hide
Permalink
Anton Khitrenovich added a comment -

Not really... I'm pretty busy at work nowadays, as you may guess.
Do you have some planned timelines for Cargo 1.1.0 to be ready?

Show
Anton Khitrenovich added a comment - Not really... I'm pretty busy at work nowadays, as you may guess. Do you have some planned timelines for Cargo 1.1.0 to be ready?
Hide
Permalink
Savas Ali Tokmen added a comment -

OK

Well, no dates set yet; but we see the end for many tasks so I'm checking

Perhaps in a few weeks

Show
Savas Ali Tokmen added a comment - OK Well, no dates set yet; but we see the end for many tasks so I'm checking Perhaps in a few weeks
Hide
Permalink
Savas Ali Tokmen added a comment -

Hi again

Any updates possible, preferably before the end of the month?

Cheers

Show
Savas Ali Tokmen added a comment - Hi again Any updates possible, preferably before the end of the month? Cheers
Hide
Permalink
Anton Khitrenovich added a comment -

Documentation updated (http://docs.codehaus.org/display/CARGO/Merging+WAR+files). Please review before closing this issue...

Show
Anton Khitrenovich added a comment - Documentation updated ( http://docs.codehaus.org/display/CARGO/Merging+WAR+files ). Please review before closing this issue...
Hide
Permalink
Anton Khitrenovich added a comment -

@Ali: Just opened CARGO-968 and CARGO-969 for refactoring, probably for Cargo 1.2.0...

Show
Anton Khitrenovich added a comment - @Ali: Just opened CARGO-968 and CARGO-969 for refactoring, probably for Cargo 1.2.0...
Hide
Permalink
Savas Ali Tokmen added a comment -

Looks good to me, Anton I've rearranged some minor style stuff, and also changed the target version for the two new issues.

Thank you, and please feel free to close this ticket if you also believe it's good.

Show
Savas Ali Tokmen added a comment - Looks good to me, Anton I've rearranged some minor style stuff, and also changed the target version for the two new issues. Thank you, and please feel free to close this ticket if you also believe it's good.

People

  • Assignee:
    Anton Khitrenovich
    Reporter:
    Vaishakh Nadgir
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: