Cargo

Consolidate Deployable.isExpanded() and isExpanded*()

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.0.6
  • Fix Version/s: 1.1.0
  • Component/s: Core
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    1

Description

The API currently has Deployable.isExpanded(), RAR.isExpandedRar(), SAR.isExpandedSar(), WAR.isExpandedWar(). The isExpanded*() methods in the subclasses seem superfluous and confusing. With Cargo 1.1 upcoming, this might be a good opportunity to either remove or deprecate the methods from the subclasses in favor of the general Deployable.isExpanded().

On a related note, the presence of Deployable.isExpanded() suggests that CARGO-290 is obsolete.

  1. Text File
    expanded.patch
    03/Mar/11 12:36 PM
    9 kB
    Benjamin Bentmann

Issue Links

is related to

Task - A task that needs to be done. CARGO-905 Remove the deprecated Deployable.isExpanded*()

  • Trivial - Cosmetic problem like misspelt words or misaligned text.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Improvement - An improvement or enhancement to an existing feature or task. CARGO-290 Make expanded WAR a proper deployable type

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Savas Ali Tokmen added a comment -

Any patch propositions?

Show
Savas Ali Tokmen added a comment - Any patch propositions?
Hide
Permalink
Anders Hammar added a comment -

I'm in favor of depracating in v1.1. We can remove in a later major (or possibly minor) release.

Show
Anders Hammar added a comment - I'm in favor of depracating in v1.1. We can remove in a later major (or possibly minor) release.
Hide
Permalink
Savas Ali Tokmen added a comment -

Committed revision 2702.

Show
Savas Ali Tokmen added a comment - Committed revision 2702.

People

  • Assignee:
    Savas Ali Tokmen
    Reporter:
    Benjamin Bentmann
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: