Cargo

Support of DirectoryConfiguration

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 1.0.4
  • Fix Version/s: None
  • Component/s: Core
  • Labels:
    None
  • Complexity:
    Intermediate
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

The following patch adds support for directory configuration. This allows to not only copy one file but a set of file based on a root directory and a set of includes/excludes patterns.

The patch is rather limited and needs a second round, namely:

  • The configfile property is not supported as the underlying implementation uses the Ant copy task to do the job
  • The overwrite property is not supported either as it would be better to handle overwriting on file-by-file basis instead of the whole directory

I haven't found a way to improve this with the current code base. However, a second patch will follow for the Maven plugin that will provide extra configuration option for directories, using the Plexus directory scanner. That way, we'll be able to build the set of FileConfig based on the files to copy and apply proper overwriting/filtering.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Savas Ali Tokmen added a comment -

Hello Stephane

I have trouble reading your patch since it has changes in the code style mixed with the functional changes.

Can you please only send the functional changes, or even perhaps send two files (one with the style changes on the existing code, another with the functional changes) ?

Thank you

Show
Savas Ali Tokmen added a comment - Hello Stephane I have trouble reading your patch since it has changes in the code style mixed with the functional changes. Can you please only send the functional changes, or even perhaps send two files (one with the style changes on the existing code, another with the functional changes) ? Thank you
Hide
Permalink
Stéphane Nicoll added a comment -

you mean code format? I tried to restrict this as little as possible. Each file that is in the patch has actually been touched. Applying the patch in your IDE should help no?

Show
Stéphane Nicoll added a comment - you mean code format? I tried to restrict this as little as possible. Each file that is in the patch has actually been touched. Applying the patch in your IDE should help no?
Hide
Permalink
Savas Ali Tokmen added a comment -

Yes, I do mean code format.

Keeping the patch only contain the changes for the added functionality is essential for all of us to understand things easier.

We can of course later on patch changes for the formatting (which are obviously good, for example removal of tabs and spaces in empty lines)

Show
Savas Ali Tokmen added a comment - Yes, I do mean code format. Keeping the patch only contain the changes for the added functionality is essential for all of us to understand things easier. We can of course later on patch changes for the formatting (which are obviously good, for example removal of tabs and spaces in empty lines)
Hide
Permalink
Stéphane Nicoll added a comment -

well, ok. I'll do a diff on all the files here and produce another patch.

Show
Stéphane Nicoll added a comment - well, ok. I'll do a diff on all the files here and produce another patch.
Hide
Permalink
Stéphane Nicoll added a comment -

here you go

Show
Stéphane Nicoll added a comment - here you go
Hide
Permalink
Stéphane Nicoll added a comment -

apparently, I hit a bug in Idea X where it does not save my changes in the diff view. That's why the second patch looked quite similar to the original one. Trying again on 9.0.4

Show
Stéphane Nicoll added a comment - apparently, I hit a bug in Idea X where it does not save my changes in the diff view. That's why the second patch looked quite similar to the original one. Trying again on 9.0.4
Hide
Permalink
Savas Ali Tokmen added a comment -

ok... waiting for you, then

Show
Savas Ali Tokmen added a comment - ok... waiting for you, then
Hide
Permalink
Stéphane Nicoll added a comment -

sorry for taking so long but I just hit an annoying issue with IDEA actually:
http://youtrack.jetbrains.net/issue/IDEA-61596

Do you really really really need the formatting style to go away? I mean you can just apply the patch locally and you'll be able to see what that brings.

Show
Stéphane Nicoll added a comment - sorry for taking so long but I just hit an annoying issue with IDEA actually: http://youtrack.jetbrains.net/issue/IDEA-61596 Do you really really really need the formatting style to go away? I mean you can just apply the patch locally and you'll be able to see what that brings.
Hide
Permalink
Savas Ali Tokmen added a comment -

hmm... can you send a patch file without any code change first?

Show
Savas Ali Tokmen added a comment - hmm... can you send a patch file without any code change first?
Hide
Permalink
Savas Ali Tokmen added a comment -

you could do that by, for example, checking out the code, changing a useless line in the files you modify (add a space after an expression, for example), saving and extracting the patch.

Show
Savas Ali Tokmen added a comment - you could do that by, for example, checking out the code, changing a useless line in the files you modify (add a space after an expression, for example), saving and extracting the patch.
Hide
Permalink
Savas Ali Tokmen added a comment -

Hello Stéphane

Any news?

Show
Savas Ali Tokmen added a comment - Hello Stéphane Any news?
Hide
Permalink
Savas Ali Tokmen added a comment -

Functionality provided via http://cargo.codehaus.org/Configuration+files+option

Show
Savas Ali Tokmen added a comment - Functionality provided via http://cargo.codehaus.org/Configuration+files+option

People

  • Assignee:
    Unassigned
    Reporter:
    Stéphane Nicoll
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: