Cargo

Cargo Jetty should support external jetty-env.xml file

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0.3
  • Fix Version/s: 1.2.2
  • Component/s: Jetty
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

By default, Jetty looks for a jetty-env.xml file in the WEB-INF directory of a web-app. However, for web application wishing to externalize their JNDI configuration, this file can (and should) by placed outside the WAR file. This file can be supplied as a command line argument when starting Jetty with start.jar. As an alternative, this file can be supplied to the Maven jetty plugin using the <jettyEnvXML> tag.

For what it is worth this tag is implemented by using the "setJettyEnvXml" method on the Jetty API class EnvConfiguration in the org.mortbay.jetty.plus.webapp package. I think approach could be used to set the jetty-env.xml location via the API, but a property is needed to supply the location of the file.

Alternatively, if the container has a configuration file specified with the name "jetty-env.xml" perhaps Cargo could detect this and hand the file location to Jetty.

Either way, it would be a great benefit for those Jetty web application wishing to externalize JNDI configuration. I do not know of any work-around.

Issue Links

relates to

Improvement - An improvement or enhancement to an existing feature or task. CARGO-556 Jetty6x- Allow configuration of all parameters that maven-jetty-plugin allows e.g. overrideWebXml

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Task - A task that needs to be done. CARGO-666 Document configFiles option

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Savas Ali Tokmen added a comment -

Hello

Can you provide a patch with testcases?

Thank you

Show
Savas Ali Tokmen added a comment - Hello Can you provide a patch with testcases? Thank you
Hide
Permalink
David H Vree added a comment -

I have just discovered a closely related problem to this issue, which perhaps could be addressed at the same time. Currently, only the Jetty Installed deployer (Jetty6xInstalledLocalDeployer) supports the Jetty Plus capabilities. This was added in the following issue:

http://jira.codehaus.org/browse/CARGO-804

However, the embedded deployer (Jetty6xEmbeddedLocalDeployer) does not have this capability, so it would need to be addressed to complete this issue as well. I believe that the installed and embedded deployers should have the same capabilities - if nothing else for the sake of consistency.

Show
David H Vree added a comment - I have just discovered a closely related problem to this issue, which perhaps could be addressed at the same time. Currently, only the Jetty Installed deployer (Jetty6xInstalledLocalDeployer) supports the Jetty Plus capabilities. This was added in the following issue: http://jira.codehaus.org/browse/CARGO-804 However, the embedded deployer (Jetty6xEmbeddedLocalDeployer) does not have this capability, so it would need to be addressed to complete this issue as well. I believe that the installed and embedded deployers should have the same capabilities - if nothing else for the sake of consistency.
Hide
Permalink
David H Vree added a comment -

@Savas - I will attempt to create a test case and patch, but Cargo is entirely new to me and this will likely take some time.

Show
David H Vree added a comment - @Savas - I will attempt to create a test case and patch, but Cargo is entirely new to me and this will likely take some time.
Hide
Permalink
Savas Ali Tokmen added a comment -

Hello

For the second issue, please open another JIRA ticket so we can track these easier.

Cheers

Show
Savas Ali Tokmen added a comment - Hello For the second issue, please open another JIRA ticket so we can track these easier. Cheers
Hide
Permalink
David H Vree added a comment -

Done:

http://jira.codehaus.org/browse/CARGO-862

Show
David H Vree added a comment - Done: http://jira.codehaus.org/browse/CARGO-862
Hide
Permalink
Savas Ali Tokmen added a comment -

Great, thanks

Show
Savas Ali Tokmen added a comment - Great, thanks
Hide
Permalink
Adrian Shum added a comment -

This issue seems abandoned for quite some time and I am facing problem which is related to this. I wish I can help on this issue but I am really a novice in Cargo. It will be great if someone can give me a hint which part to look into, and if the enhancement is also suitable for Jetty 7 and 8.

Show
Adrian Shum added a comment - This issue seems abandoned for quite some time and I am facing problem which is related to this. I wish I can help on this issue but I am really a novice in Cargo. It will be great if someone can give me a hint which part to look into, and if the enhancement is also suitable for Jetty 7 and 8.
Hide
Permalink
Savas Ali Tokmen added a comment -

Hi Adrian

Since the opening of this bug, many things changed; in particular https://jira.codehaus.org/browse/CARGO-1083 has been implemented and the Jetty container now supports existing local configuration.

I would suggest for you to either read the documentation for existing configurations or send an e-mail to user@cargo.codehaus.org and request help -luckily Eduardo would be able of helping you out.

Thank you

Show
Savas Ali Tokmen added a comment - Hi Adrian Since the opening of this bug, many things changed; in particular https://jira.codehaus.org/browse/CARGO-1083 has been implemented and the Jetty container now supports existing local configuration. I would suggest for you to either read the documentation for existing configurations or send an e-mail to user@cargo.codehaus.org and request help -luckily Eduardo would be able of helping you out. Thank you
Hide
Permalink
Savas Ali Tokmen added a comment -

Now documented in http://cargo.codehaus.org/Configuration+files+option

Show
Savas Ali Tokmen added a comment - Now documented in http://cargo.codehaus.org/Configuration+files+option

People

  • Assignee:
    Savas Ali Tokmen
    Reporter:
    David H Vree
Vote (2)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: