Cargo

Enhance documententation for cargo.rmi.port and cargo.jboss.naming.port

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.0.3
  • Fix Version/s: 1.0.4
  • Component/s: Documentation, JBoss
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

In the cargo maven plugin you have to set <cargo.rmi.port> in case of not using the default jboss port.
To know the port I have opened my jboss_home/server/default/conf/bindingservice.beans/META-INF/bindings-jboss-beans.xml and look for the rmi port.
I found this :

<bean class="org.jboss.services.binding.ServiceBindingMetadata">
<property name="serviceName">jboss:service=Naming</property>
<property name="bindingName">Port</property>
<property name="port">1299</property>
<property name="description">The listening socket for the Naming service</property>
</bean>

<bean class="org.jboss.services.binding.ServiceBindingMetadata">
<property name="serviceName">jboss:service=Naming</property>
<property name="bindingName">RmiPort</property>
<property name="port">1098</property>
<property name="description">Socket Naming service uses to receive RMI requests from client proxies</property>
</bean>

So I put 1098 for the <cargo.rmi.port> instead of the 1299...
I think cargo.rmi.port might be badly named...

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Savas Ali Tokmen added a comment -

Hello

Indeed, the jboss6x container clearly shows we've inversed something:

            <!-- Naming Service -->
            <bean class="org.jboss.services.binding.ServiceBindingMetadata">
               <property name="serviceName">jboss:service=Naming</property>
               <property name="bindingName">Port</property>
               <property name="port">@cargo.rmi.port@</property>
               <property name="description">The listening socket for the Naming service</property>
            </bean>

            <bean class="org.jboss.services.binding.ServiceBindingMetadata">
               <property name="serviceName">jboss:service=Naming</property>
               <property name="bindingName">RmiPort</property>
               <property name="port">@cargo.jboss.naming.port@</property>
               <property name="description">Socket Naming service uses to receive RMI requests from client proxies</property>
            </bean>

I think it has been done that way so that JBoss can act like the other containers: in other container, to look up EJBs for example, you use the JNDI registry on the (only) RMI port. If we inverse, then people testing EJBs on JBoss will need to invert.

Hence, I think the current way of working is better.

What do you think?

Show
Savas Ali Tokmen added a comment - Hello Indeed, the jboss6x container clearly shows we've inversed something: <!-- Naming Service --> <bean class="org.jboss.services.binding.ServiceBindingMetadata"> <property name="serviceName">jboss:service=Naming</property> <property name="bindingName">Port</property> <property name="port">@cargo.rmi.port@</property> <property name="description">The listening socket for the Naming service</property> </bean> <bean class="org.jboss.services.binding.ServiceBindingMetadata"> <property name="serviceName">jboss:service=Naming</property> <property name="bindingName">RmiPort</property> <property name="port">@cargo.jboss.naming.port@</property> <property name="description">Socket Naming service uses to receive RMI requests from client proxies</property> </bean> I think it has been done that way so that JBoss can act like the other containers: in other container, to look up EJBs for example, you use the JNDI registry on the (only) RMI port. If we inverse, then people testing EJBs on JBoss will need to invert. Hence, I think the current way of working is better. What do you think?
Hide
Permalink
Savas Ali Tokmen added a comment -

As discussed on http://old.nabble.com/Re%3A--cargo-dev---jira--Created%3A-%28CARGO-849%29-Change-%3Ccargo.rmi.port%3E-to-%3Ccargo.naming.port%3E-to29832984.html#a29832984 this issue has been fixed by updating documentation.

Committed revision 2497.

Show
Savas Ali Tokmen added a comment - As discussed on http://old.nabble.com/Re%3A--cargo-dev---jira--Created%3A-%28CARGO-849%29-Change-%3Ccargo.rmi.port%3E-to-%3Ccargo.naming.port%3E-to29832984.html#a29832984 this issue has been fixed by updating documentation. Committed revision 2497.
Savas Ali Tokmen made changes -
Field Original Value New Value
Status Open [ 1 ] Closed [ 6 ]
Assignee Savas Ali Tokmen [ alitokmen ]
Fix Version/s 1.0.4 [ 16707 ]
Resolution Fixed [ 1 ]
Savas Ali Tokmen made changes -
Component/s Documentation [ 11434 ]
Summary Change <cargo.rmi.port> to <cargo.naming.port> Enhance documententation for cargo.rmi.port and cargo.jboss.naming.port

People

  • Assignee:
    Savas Ali Tokmen
    Reporter:
    Griboval Philippe
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: