Cargo

Capability property is added to wrong Map object for JBoss

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.0.2
  • Fix Version/s: 1.0.3
  • Component/s: JBoss
  • Labels:
    None
  • Environment:
    n/a
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

While browsing the JBoss code I found this in that surely must be a simple typing error:

org.codehaus.cargo.container.jboss.internal.JBossStandaloneLocalConfigurationCapability.java
    public JBossStandaloneLocalConfigurationCapability()
    {
        super();

        this.propertySupportMap = new HashMap();
        this.defaultSupportsMap.put(GeneralPropertySet.HOSTNAME, Boolean.TRUE);
        this.propertySupportMap.put(GeneralPropertySet.PROTOCOL, Boolean.FALSE);
        this.propertySupportMap.put(ServletPropertySet.USERS, Boolean.FALSE);
        this.propertySupportMap.put(JBossPropertySet.CONFIGURATION, Boolean.TRUE);
        ...
    }

Note that HOSTNAME is put in a different map (defaultSupportsMap belongs to the extended class) than all other capability properies. Checking the code I believe that the net effect is zero as the two maps are merged to get the sum of capabilities. But it's weird anyhow!

Activity

Hide
Permalink
Anders Hammar added a comment -

Fixed in r2427 in trunk

Show
Anders Hammar added a comment - Fixed in r2427 in trunk

People

  • Assignee:
    Anders Hammar
    Reporter:
    Anders Hammar
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: