Cargo

s/with a blank password admin/with a blank admin password/
s/black password/blank password/

Why can't edit the issue I have created?

Updated description.

Fixed SVN rev. 2403

using maven2 extension 1.0.3-SNAPSHOT (timestamp 20100723.191118) and setting <cargo.remote.password></cargo.remote.password> in my pom, the plugin try to use password ocnfigured in the temp folder:

[WARNING] [talledLocalContainer] Authentication failed for user: admin
[WARNING] [talledLocalContainer] with password from password file: /tmp/cargo/conf/password.properties
[WARNING] [talledLocalContainer] (Usually, this means invalid user name and/or password)

i would like to re-open this issue

Reopening as requested.

this file /tmp/cargo/conf/password.properties is in my filesystem before i fix the configuration for empty passwords, maybe that file has priority on configuration properties...

Th,s might be because the CARGO GF container doesn't rewrite and existing passwords file.

Should that also be changed?

If it's true what Riccardo says, cargo.remote.password property should have bigger priority than password.properties. But I will check it myself and let you know in a few days.

Where is the 1.0.3-SNAPSHOT version of cargo-maven2-plugin available to download? I came to http://bamboo.ci.codehaus.org/browse/CARGO-TRUNKM2JDK15-614/artifact but I see there only Maven 1 plugin. I thought it's a typo, so I did mvn install:install-file, but, yes, this was a Maven 1 plugin because it doesn't work (The plugin descriptor for the plugin Plugin [org.codehaus.cargo:cargo-maven2-plugin] was not found. Please verify that the plugin JAR [...] is intact.)

The latest snapshot is on the http://snapshots.repository.codehaus.org/ repository.

I still get the same exception (org.codehaus.cargo.util.CargoException: password needs to be 8 characters or longer). I suppose I haven't configured the dependencies correctly - could you please check if it's correct?

<pluginRepositories>
	<pluginRepository>
		<id>codehaus snapshots</id>
		<url>http://snapshots.repository.codehaus.org/</url>
	</pluginRepository>
</pluginRepositories>

<plugin>
	<groupId>org.codehaus.cargo</groupId>
	<artifactId>cargo-maven2-plugin</artifactId>
	<version>1.0.3-SNAPSHOT</version>
	...
</plugin>

Hmmm.... The trouble is that snapshots need to be deployed manually, perhaps I did not deploy them after the change.

Can you check out the CARGO source code and compile, please?

If not I can also redeploy.

I checked out the sources and I am building it at the moment.

You have fixed the bug with 8-chars password but introduced a very little one as Riccardo said. Everything is good if /tmp/cargo/conf/password.properties doesn't exist. cargo.remote.password property is used, put into the file and deployed. But the file remains - and when password is changed, plugin won't notice that. Just imagine someone who doesn't remember the admin password - he will be given only one chance to guess a password, other tries will use the first password in spite of the fact he provided a new one. password.properties file should be deleted just after the redeploy - there is no need to keep it I guess (tell me if I am wrong).

Patch proposals?

Cheers

I will take a look into the code in a few days and let you know.

The code does not rwrite the file anymore:

            File f = new File(this.getHome(), "password.properties");
            if (!f.exists())
            {
                this.getFileHandler().mkdirs(this.getHome());
                FileWriter w = new FileWriter(f);
                // somehow glassfish uses both. Brain-dead.
                w.write("AS_ADMIN_PASSWORD=" + password + "\n");
                w.write("AS_ADMIN_ADMINPASSWORD=" + password + "\n");
                w.close();
            }
            return f;