'Username' attribute for Tomcat5x configuration

I set the incorrect Affects Version, it's 1.0. I can't edit it.

"tomcat6x" configuration is affected too. Attached trivial patch resolving this issue.

I have verified that the patch works on the 1.0.1-SNAPSHOT code with tomcat6x.

Both Tomcat 5.5. and 6.0 use "username" as attribute.

http://tomcat.apache.org/tomcat-5.5-doc/jndi-resources-howto.html says:

<Resource name="jdbc/EmployeeDB" auth="Container"
type="javax.sql.DataSource" username="dbusername" password="dbpassword"
driverClassName="org.hsql.jdbcDriver" url="jdbc:HypersonicSQL:database"
maxActive="8" maxIdle="4"/>

http://tomcat.apache.org/tomcat-6.0-doc/jndi-datasource-examples-howto.html says:

<Resource name="jdbc/TestDB" auth="Container" type="javax.sql.DataSource"
maxActive="100" maxIdle="30" maxWait="10000"
username="javauser" password="javadude" driverClassName="com.mysql.jdbc.Driver"
url="jdbc:mysql://localhost:3306/javatest?autoReconnect=true"/>

As a result, looks like no Tomcat version has a "user" attribute.

Did anyone test with the "user" attribute?

Meanwhile, Tomcat 4.x and 5.0 have a completely different JDBC configuration. See http://tomcat.apache.org/tomcat-4.1-doc/jndi-datasource-examples-howto.html for details.

Is there any sort of timeline when this 6-month old bug may be fixed? Or, at the very least, the submitted patch committed to trunk? Only after a couple of hours of frustration did I happen upon this bug. It would be nice to save future developers from experiencing the same. Even a blurb within cargo's documentation, warning users of the problem, might provide sufficient mercy to those who bump up against this issue.

Thankfully, a workaround to this issue has been described here:

http://old.nabble.com/Looking-for-best-way-to-have-Cargo-inject-two-kinds-of--resources-td24358459.html#a24393907

Essentially, adding an additional datasource property like so will produce a workable context.xml file:

cargo.datasource.properties=username=[db user]

where [db user] is you database username. Do note that the two equal symbols is not a typo.

Applying patch: the property is "username" (and not "user") in Tomcat 4.0 and 5.0 as well!

See:

http://tomcat.apache.org/tomcat-4.1-doc/jndi-datasource-examples-howto.html
http://www.apache-korea.org/tomcat/tomcat-5.0-doc/jndi-datasource-examples-howto.html

Completed: At revision: 2030

Closing issue, tests have been fixed as well.

Completed: At revision: 2032