Cargo

Create Coding and Style conventions for Java 5

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.0.2
  • Component/s: Core
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

When we switch to use Java 5, we should review our checkstyle sheets. We need to decide which constructs to enforce and which standards to modify or drop. For example, should we enforce @Override? Should we drop mandatory javadocs for private members?

Issue Links

is depended upon by

Improvement - An improvement or enhancement to an existing feature or task. CARGO-656 Refactor Cargo to use JDK 5 apis

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Savas Ali Tokmen added a comment -

Targeting 1.0.2

The checkstyle should also get compatible with generics

Show
Savas Ali Tokmen added a comment - Targeting 1.0.2 The checkstyle should also get compatible with generics
Hide
Permalink
Savas Ali Tokmen added a comment -

Done, added enforced @Override and upgraded checkstyle version so we can handle generics

Checkstyle doesn't come with a rule that enforces generics, thought. That's a pity.

Show
Savas Ali Tokmen added a comment - Done, added enforced @Override and upgraded checkstyle version so we can handle generics Checkstyle doesn't come with a rule that enforces generics, thought. That's a pity.
Hide
Permalink
Anders Hammar added a comment -

r2316 actually removed the checkstyle plugin executions and should be reverted. Please also verify all other related commits as I haven't done that.

Show
Anders Hammar added a comment - r2316 actually removed the checkstyle plugin executions and should be reverted. Please also verify all other related commits as I haven't done that.
Hide
Permalink
Savas Ali Tokmen added a comment -

You're right -now fixing it for real.

I owe you one for this one, Anders

Thanks for the quick spotting

Show
Savas Ali Tokmen added a comment - You're right -now fixing it for real. I owe you one for this one, Anders Thanks for the quick spotting
Hide
Permalink
Savas Ali Tokmen added a comment -

Committed revision 2330.

Show
Savas Ali Tokmen added a comment - Committed revision 2330.

People

  • Assignee:
    Savas Ali Tokmen
    Reporter:
    Adrian Cole
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: