Cargo

The cargo.jvmargs element is instable against formatting.

Details

  • Complexity:
    Intermediate
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

If I pass two jvm properties, this works.

<cargo.jvmargs>
-Dx.y=z -Du.v=w
</cargo.jvmargs>

After reformatting the xml with my Eclipse WTP xml editor it looks like the following:

<cargo.jvmargs>
-Dx.y=z
-Du.v=w
</cargo.jvmargs>

Now the properties are not passed correctly. In my case this was hard to debug.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vincent Massol added a comment -

Hi Hans,

Well, we don't control that. I'd say this should be in improvement to log against Maven itself as it's maven that passed the config to our plugin.

Thanks
-Vincent

Show
Vincent Massol added a comment - Hi Hans, Well, we don't control that. I'd say this should be in improvement to log against Maven itself as it's maven that passed the config to our plugin. Thanks -Vincent
Hide
Permalink
Hans Dockter added a comment -

Hi Vincent,

another possible fix would be:

<cargo.jvmargs>
<cargo.jvmarg>
-Dx.y=z
</cargo.jvmarg>
<cargo.jvmarg>
-Du.v=w
</cargo.jvmarg>
</cargo.jvmargs>

That would be also a more xml typical way of handling collection of values.

Anyway, I file an issue against Maven as well.

Thanks,

Hans

Show
Hans Dockter added a comment - Hi Vincent, another possible fix would be: <cargo.jvmargs> <cargo.jvmarg> -Dx.y=z </cargo.jvmarg> <cargo.jvmarg> -Du.v=w </cargo.jvmarg> </cargo.jvmargs> That would be also a more xml typical way of handling collection of values. Anyway, I file an issue against Maven as well. Thanks, Hans
Hide
Permalink
Vincent Massol added a comment -

yes it would but I don't know if you can do this... We're using the Properties feature of Maven... (these props are dynamic). Also in that case you could remove the -D...

Show
Vincent Massol added a comment - yes it would but I don't know if you can do this... We're using the Properties feature of Maven... (these props are dynamic). Also in that case you could remove the -D...
Hide
Permalink
Vincent Massol added a comment -

... and have <name>x.y</name><value>z</value>

but you're going to find it's taking long to type...

Show
Vincent Massol added a comment - ... and have <name>x.y</name><value>z</value> but you're going to find it's taking long to type...
Hide
Permalink
Savas Ali Tokmen added a comment - - edited

Completed: At revision: 2016

The fix removes all new lines from the parsed XML. This fixes the issue for most cases.

Show
Savas Ali Tokmen added a comment - - edited Completed: At revision: 2016 The fix removes all new lines from the parsed XML. This fixes the issue for most cases.

People

  • Assignee:
    Savas Ali Tokmen
    Reporter:
    Hans Dockter
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: