Issue Details (XML | Word | Printable)

Key: CARGO-491
Type: New Feature New Feature
Status: Open Open
Priority: Trivial Trivial
Assignee: Unassigned
Reporter: Marwan Zeineddine
Votes: 23
Watchers: 22
Operations

If you were logged in you would be able to see more operations.
Cargo

Add support for Glassfish

Created: 13/Feb/07 05:03 AM   Updated: 05/Nov/09 08:36 AM
Return to search
Component/s: Glassfish
Affects Version/s: 0.8
Fix Version/s: None

Time Tracking:
Not Specified

File Attachments: 1. File CARGO-491_draft_v1.diff (65 kB)
2. Text File patch.txt (1 kB)

Environment: Sun OS 10/SPARC, Sun Java System Application Server Platform Edition 9.0_01

Complexity: Intermediate


 Description  « Hide

Attempting to finish work initiated by Kohsuke Kawagushi. I am following the standard procedure for adding a container. I have searched the bug database for anything relating to glassfish or sun app server and didn't find any, i may have missed some.



Vincent Massol added a comment - 13/Feb/07 08:06 AM

That's great news Marwan! You probably already know that but there's preliminary support in Cargo's contrib repo. I could give you write access if you're interested. Just log in on Xircles and ask to be a Cargo project contributor and let me know.


Vincent Massol made changes - 13/Feb/07 08:07 AM
Field Original Value New Value
Component/s Build [ 11712 ]
Component/s Core [ 11431 ]
Component/s Maven2 [ 11970 ]
Component/s Documentation [ 11434 ]
Affects Version/s 0.8 [ 12191 ]
Component/s Generic [ 11433 ]
Component/s Glassfish [ 12591 ]
Jerome Lacoste added a comment - 29/Mar/07 09:00 AM

Marwan, I need to deploy to Sun AppServer 8.1. Not sure if that the implementation you envision fopr glassfish support will be compatible with it. If it is, I will be able to give you some help.

What's your status ?


Jerome Lacoste added a comment - 05/Apr/07 04:22 AM

questions:

  • Is there any unfisnished code available somewhere ? Marwan ? Kohsuke ?
  • integrating using asadmin looks like the common way. NetBeans code does it.

See also http://www.jaceklaskowski.pl/w/index.php?title=Tworzenie_aplikacji_Java_EE_5_z_Apache_Maven_2_i_Glassfish


Jerome Lacoste added a comment - 19/Dec/07 01:09 PM

For information we're working on this (support for Sun AS 8.1 and 9.0).


Jerome Lacoste added a comment - 19/Dec/07 01:26 PM

Attached a first version of the support for Sun AS. Tested with Sun AS 8.1 and 9.0.

Wasn't developed by me (I will add the developer name when we're done), and I haven't tested it yet. Just wanted to upload it in case my disk (or me) dies.

I will now test the code and review it before submitting it again for inclusion.


Jerome Lacoste made changes - 19/Dec/07 01:26 PM
Attachment CARGO-491_draft_v1.diff [ 31345 ]
Paul Philion added a comment - 05/Mar/08 06:44 PM

Can anyone comment on the current status of this? I would really like Glassfish support in Cargo and I can contribute some development cycles.


Kem Elbrader added a comment - 27/Mar/08 03:12 PM

Ditto. I'd really like Glassfish support and would be willing to help in any way possible.


Matt Wringe added a comment - 27/Mar/08 03:34 PM

If you are willing to help there are some docs available on the website to help you get started:
http://cargo.codehaus.org/Contributing
http://cargo.codehaus.org/Adding+a+container

Join the mailing lists (http://cargo.codehaus.org/Mailing+Lists) and irc channel (http://cargo.codehaus.org/IRC).


Kohsuke Kawaguchi added a comment - 23/Apr/08 12:47 PM

The current work is available in http://svn.codehaus.org/cargo-contrib/glassfish

I believe all that's missing is the reformatting of the code to meet the chekstyle rules (if that's still in place), and have some test cases, which is a requirement AIU.


Vlad Postudor added a comment - 03/Jun/08 03:44 AM

In last days I took the sources commited by Kawaguchi ,integrated to work in Cargo and now I'm using with Maven 2. I want to commit them for adding support for the Glassfish and for what I read on "Adding a container" page it left very few steps.


Greg Luck added a comment - 06/Jun/08 05:57 AM

Vlad can you share this code somewhere. I need the same thing?

Can you attach it to this issue with some instructions perhaps.


Greg Luck added a comment - 06/Jun/08 05:59 AM

Vlad

Actually http://cargo.codehaus.org/Adding+a+container seems to be a step by step. The last step is to add the code to this issue. Please do.


Kohsuke Kawaguchi added a comment - 24/Oct/08 05:52 PM

CARGO-584 now enable the GlassFish support to be developed independently.
http://svn.codehaus.org/cargo-contrib/glassfish is updated to use this feature.

1.0-alpha-6 release of Cargo and Cargo GlassFish implementation supports v2 now.



Kohsuke Kawaguchi added a comment - 17/Jun/09 08:46 PM

I updated the code a bit and pushed 1.0 to sync up with Cargo 1.0.


Matt Wringe added a comment - 17/Jun/09 10:23 PM

Any reason why this can't be put into the regular Cargo svn?


Christopher Rued added a comment - 04/Nov/09 05:14 PM - edited

I have been having quite a bit of trouble trying to get this to run on Ant...eventually, it seems, it came down to a classloader problem. Somehow the GlassFish classes weren't found in the "Context" classpath but were in the classloader associated with the AbstractFactoryRegistry class.

Here's a patch that seems to make things work: the basic idea is to use ALL classloaders, rather than just the first one we find:

(patch attached to this issue)


Christopher Rued added a comment - 04/Nov/09 05:15 PM

Patch to have AbstractFactoryRegistry search for providers in ALL classloaders rather than just the first classloader it can find.


Christopher Rued made changes - 04/Nov/09 05:15 PM
Attachment patch.txt [ 45645 ]