Cargo

Add support for Glassfish

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.8
  • Fix Version/s: 1.0.1-beta-3, 1.0.1
  • Component/s: Glassfish
  • Labels:
    None
  • Environment:
    Sun OS 10/SPARC, Sun Java System Application Server Platform Edition 9.0_01
  • Complexity:
    Intermediate
  • Number of attachments :
    2

Description

Attempting to finish work initiated by Kohsuke Kawagushi. I am following the standard procedure for adding a container. I have searched the bug database for anything relating to glassfish or sun app server and didn't find any, i may have missed some.

  1. CARGO-491_draft_v1.diff
    19/Dec/07 1:26 PM
    65 kB
    Jerome Lacoste
  2. patch.txt
    04/Nov/09 5:15 PM
    1 kB
    Christopher Rued

Issue Links

Activity

Hide
Vincent Massol added a comment -

That's great news Marwan! You probably already know that but there's preliminary support in Cargo's contrib repo. I could give you write access if you're interested. Just log in on Xircles and ask to be a Cargo project contributor and let me know.

Show
Vincent Massol added a comment - That's great news Marwan! You probably already know that but there's preliminary support in Cargo's contrib repo. I could give you write access if you're interested. Just log in on Xircles and ask to be a Cargo project contributor and let me know.
Hide
Jerome Lacoste added a comment -

Marwan, I need to deploy to Sun AppServer 8.1. Not sure if that the implementation you envision fopr glassfish support will be compatible with it. If it is, I will be able to give you some help.

What's your status ?

Show
Jerome Lacoste added a comment - Marwan, I need to deploy to Sun AppServer 8.1. Not sure if that the implementation you envision fopr glassfish support will be compatible with it. If it is, I will be able to give you some help. What's your status ?
Hide
Jerome Lacoste added a comment -

questions:

  • Is there any unfisnished code available somewhere ? Marwan ? Kohsuke ?
  • integrating using asadmin looks like the common way. NetBeans code does it.

See also http://www.jaceklaskowski.pl/w/index.php?title=Tworzenie_aplikacji_Java_EE_5_z_Apache_Maven_2_i_Glassfish

Show
Jerome Lacoste added a comment - questions:
  • Is there any unfisnished code available somewhere ? Marwan ? Kohsuke ?
  • integrating using asadmin looks like the common way. NetBeans code does it.
See also http://www.jaceklaskowski.pl/w/index.php?title=Tworzenie_aplikacji_Java_EE_5_z_Apache_Maven_2_i_Glassfish
Hide
Jerome Lacoste added a comment -

For information we're working on this (support for Sun AS 8.1 and 9.0).

Show
Jerome Lacoste added a comment - For information we're working on this (support for Sun AS 8.1 and 9.0).
Hide
Jerome Lacoste added a comment -

Attached a first version of the support for Sun AS. Tested with Sun AS 8.1 and 9.0.

Wasn't developed by me (I will add the developer name when we're done), and I haven't tested it yet. Just wanted to upload it in case my disk (or me) dies.

I will now test the code and review it before submitting it again for inclusion.

Show
Jerome Lacoste added a comment - Attached a first version of the support for Sun AS. Tested with Sun AS 8.1 and 9.0. Wasn't developed by me (I will add the developer name when we're done), and I haven't tested it yet. Just wanted to upload it in case my disk (or me) dies. I will now test the code and review it before submitting it again for inclusion.
Hide
Paul Philion added a comment -

Can anyone comment on the current status of this? I would really like Glassfish support in Cargo and I can contribute some development cycles.

Show
Paul Philion added a comment - Can anyone comment on the current status of this? I would really like Glassfish support in Cargo and I can contribute some development cycles.
Hide
Kem Elbrader added a comment -

Ditto. I'd really like Glassfish support and would be willing to help in any way possible.

Show
Kem Elbrader added a comment - Ditto. I'd really like Glassfish support and would be willing to help in any way possible.
Hide
Matt Wringe added a comment -

If you are willing to help there are some docs available on the website to help you get started:
http://cargo.codehaus.org/Contributing
http://cargo.codehaus.org/Adding+a+container

Join the mailing lists (http://cargo.codehaus.org/Mailing+Lists) and irc channel (http://cargo.codehaus.org/IRC).

Show
Matt Wringe added a comment - If you are willing to help there are some docs available on the website to help you get started: http://cargo.codehaus.org/Contributing http://cargo.codehaus.org/Adding+a+container Join the mailing lists (http://cargo.codehaus.org/Mailing+Lists) and irc channel (http://cargo.codehaus.org/IRC).
Hide
Kohsuke Kawaguchi added a comment -

The current work is available in http://svn.codehaus.org/cargo-contrib/glassfish

I believe all that's missing is the reformatting of the code to meet the chekstyle rules (if that's still in place), and have some test cases, which is a requirement AIU.

Show
Kohsuke Kawaguchi added a comment - The current work is available in http://svn.codehaus.org/cargo-contrib/glassfish I believe all that's missing is the reformatting of the code to meet the chekstyle rules (if that's still in place), and have some test cases, which is a requirement AIU.
Hide
Vlad Postudor added a comment -

In last days I took the sources commited by Kawaguchi ,integrated to work in Cargo and now I'm using with Maven 2. I want to commit them for adding support for the Glassfish and for what I read on "Adding a container" page it left very few steps.

Show
Vlad Postudor added a comment - In last days I took the sources commited by Kawaguchi ,integrated to work in Cargo and now I'm using with Maven 2. I want to commit them for adding support for the Glassfish and for what I read on "Adding a container" page it left very few steps.
Hide
Greg Luck added a comment -

Vlad can you share this code somewhere. I need the same thing?

Can you attach it to this issue with some instructions perhaps.

Show
Greg Luck added a comment - Vlad can you share this code somewhere. I need the same thing? Can you attach it to this issue with some instructions perhaps.
Hide
Greg Luck added a comment -

Vlad

Actually http://cargo.codehaus.org/Adding+a+container seems to be a step by step. The last step is to add the code to this issue. Please do.

Show
Greg Luck added a comment - Vlad Actually http://cargo.codehaus.org/Adding+a+container seems to be a step by step. The last step is to add the code to this issue. Please do.
Hide
Kohsuke Kawaguchi added a comment -

CARGO-584 now enable the GlassFish support to be developed independently.
http://svn.codehaus.org/cargo-contrib/glassfish is updated to use this feature.

1.0-alpha-6 release of Cargo and Cargo GlassFish implementation supports v2 now.

Show
Kohsuke Kawaguchi added a comment - CARGO-584 now enable the GlassFish support to be developed independently. http://svn.codehaus.org/cargo-contrib/glassfish is updated to use this feature. 1.0-alpha-6 release of Cargo and Cargo GlassFish implementation supports v2 now.
Hide
Kohsuke Kawaguchi added a comment -

I updated the code a bit and pushed 1.0 to sync up with Cargo 1.0.

Show
Kohsuke Kawaguchi added a comment - I updated the code a bit and pushed 1.0 to sync up with Cargo 1.0.
Hide
Matt Wringe added a comment -

Any reason why this can't be put into the regular Cargo svn?

Show
Matt Wringe added a comment - Any reason why this can't be put into the regular Cargo svn?
Hide
Christopher Rued added a comment - - edited

I have been having quite a bit of trouble trying to get this to run on Ant...eventually, it seems, it came down to a classloader problem. Somehow the GlassFish classes weren't found in the "Context" classpath but were in the classloader associated with the AbstractFactoryRegistry class.

Here's a patch that seems to make things work: the basic idea is to use ALL classloaders, rather than just the first one we find:

(patch attached to this issue)

Show
Christopher Rued added a comment - - edited I have been having quite a bit of trouble trying to get this to run on Ant...eventually, it seems, it came down to a classloader problem. Somehow the GlassFish classes weren't found in the "Context" classpath but were in the classloader associated with the AbstractFactoryRegistry class. Here's a patch that seems to make things work: the basic idea is to use ALL classloaders, rather than just the first one we find: (patch attached to this issue)
Hide
Christopher Rued added a comment -

Patch to have AbstractFactoryRegistry search for providers in ALL classloaders rather than just the first classloader it can find.

Show
Christopher Rued added a comment - Patch to have AbstractFactoryRegistry search for providers in ALL classloaders rather than just the first classloader it can find.
Hide
Morten Christensen added a comment -

Did anyone upgrade the code to support glassfish v3 ?

Show
Morten Christensen added a comment - Did anyone upgrade the code to support glassfish v3 ?
Hide
Savas Ali Tokmen added a comment -

Hello

After your post, I've checked out the Glassfish code in the cargo-contrib. Last night, it simply was UNACCEPTABLE; since its source code doesn't even pass the checkstyle.

I've spent some time fixing it, now it has been released.

In CARGO version 1.0.2, Glassfish v2 and v3 shall both also be added to the official containers list. For that, it needs to be copied to the trunk (trivial) but MOSTLY it needs to have TESTS !!!

Some testing will be done at the "samples" level.

Cheers

S. Ali Tokmen
http://ali.tokmen.com/

Show
Savas Ali Tokmen added a comment - Hello After your post, I've checked out the Glassfish code in the cargo-contrib. Last night, it simply was UNACCEPTABLE; since its source code doesn't even pass the checkstyle. I've spent some time fixing it, now it has been released. In CARGO version 1.0.2, Glassfish v2 and v3 shall both also be added to the official containers list. For that, it needs to be copied to the trunk (trivial) but MOSTLY it needs to have TESTS !!! Some testing will be done at the "samples" level. Cheers S. Ali Tokmen http://ali.tokmen.com/
Hide
Morten Christensen added a comment -

I did test yesterday with glassfish 3 and it would not recognize "glassfish3" as a container id. Once you think it is ready, I can help you test it on my glassfish v3 ?

Show
Morten Christensen added a comment - I did test yesterday with glassfish 3 and it would not recognize "glassfish3" as a container id. Once you think it is ready, I can help you test it on my glassfish v3 ?
Hide
Savas Ali Tokmen added a comment -

What I'd suggest is to try to execute Glassfish 3.x using the glassfish2 container.

In 1.0.1-beta-2, there are two containers; thought: glassfish2x and glassfish3x

They all use the same Java classes

Show
Savas Ali Tokmen added a comment - What I'd suggest is to try to execute Glassfish 3.x using the glassfish2 container. In 1.0.1-beta-2, there are two containers; thought: glassfish2x and glassfish3x They all use the same Java classes
Hide
Savas Ali Tokmen added a comment -

GlassFish 2.x and 3.x will land with CARGO 1.0.1, as "experimental".

Show
Savas Ali Tokmen added a comment - GlassFish 2.x and 3.x will land with CARGO 1.0.1, as "experimental".
Hide
Christopher Rued added a comment - - edited

Fantastic news! Thanks, @savas!

Show
Christopher Rued added a comment - - edited Fantastic news! Thanks, @savas!
Hide
Savas Ali Tokmen added a comment -

Sure If you can access the CARGO SVN, can you please try the revision 2135? It should work on Glassfish 2.x (tested with Glassfish 2.2.1 b31g on MacOS X)

Show
Savas Ali Tokmen added a comment - Sure If you can access the CARGO SVN, can you please try the revision 2135? It should work on Glassfish 2.x (tested with Glassfish 2.2.1 b31g on MacOS X)
Hide
Savas Ali Tokmen added a comment -

Working as of rev. 2133

Show
Savas Ali Tokmen added a comment - Working as of rev. 2133

People

Vote (23)
Watch (22)

Dates

  • Created:
    Updated:
    Resolved: