Cargo

Cargo container instances need a unique identifier

Details

  • Type: Improvement Improvement
  • Status: Reopened Reopened
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 0.9
  • Fix Version/s: 1.5.0
  • Component/s: Core, Maven2
  • Labels:
    None
  • Complexity:
    Intermediate
  • Testcase included:
    yes
  • Number of attachments :
    1

Description

The maven2 cargo plugin keeps track of a container which it creates in the global Maven context, preventing multiple containers from being run at once (CARGO-421). To store containers properly in the Maven context, each container created needs a unique identifier which can be specified in the configuration.

You can see our fix in the attached patch file (against HEAD), and why it isn't ideal. I've also included a test case which passes after the patch is applied.

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. CARGO-421 Starting & Deploying Multiple Containers

  • Critical - Crashes, loss of data, severe memory leak.
  • Open - The issue is open and ready for the assignee to start work on it.

New Feature - A new feature of the product, which has yet to be developed. CARGO-541 allow multiple instances of the appserver to be running

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Wish - General wishlist item CARGO-572 Allow deploy to several remote server

  • Critical - Crashes, loss of data, severe memory leak.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matt Wringe added a comment -

committed into svn head

Show
Matt Wringe added a comment - committed into svn head
Hide
Permalink
Denis VERGNES added a comment -

It seems to me incomplete for some configuration such as a runtime one. In this case you can't specify a home so multiple containers can't be distinguished.

Show
Denis VERGNES added a comment - It seems to me incomplete for some configuration such as a runtime one. In this case you can't specify a home so multiple containers can't be distinguished.
Hide
Permalink
Matt Wringe added a comment -

Issues with multiple runtime containers will still cause problems.

We should add a user settable id configuration option to handle this situation.

Show
Matt Wringe added a comment - Issues with multiple runtime containers will still cause problems. We should add a user settable id configuration option to handle this situation.
Hide
Permalink
Matt Ryall added a comment -

Sorry, I should have been clearer in my initial description. The attached patch uses the instance home directory as a surrogate unique key for each instance. This is not ideal, and as Matt W points out, the proper solution requires Cargo to allow an identifier to be included with each configuration.

Show
Matt Ryall added a comment - Sorry, I should have been clearer in my initial description. The attached patch uses the instance home directory as a surrogate unique key for each instance. This is not ideal, and as Matt W points out, the proper solution requires Cargo to allow an identifier to be included with each configuration.

People

  • Assignee:
    Unassigned
    Reporter:
    Matt Ryall
Vote (10)
Watch (7)

Dates

  • Created:
    Updated: