Cargo

Fix redeploy method for Tomcat container to perform actual undeploy and deploy instead of reload

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.8
  • Fix Version/s: 0.9
  • Component/s: Tomcat
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    2

Description

Update redeploy method for Tomcat container to perform actual undeploy and deploy instead of reload.
Current redeploy method contains call for reload method of Tomcat Manager instead of performing undeploying and deploying deployable.

  1. Text File
    patch.txt
    15/Oct/06 4:58 PM
    0.9 kB
    Juri Artamonov
  2. Text File
    redeploy.patch
    30/Oct/06 4:13 AM
    1 kB
    Aaron Digulla

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vincent Massol added a comment -

Hi Juri,

Thanks. It'll good to have first a test that fails, showing the error and then applying the patch and showing that it works.

I'll have a look later in the week if you don't beat me to it...

Thanks
-Vincent

Show
Vincent Massol added a comment - Hi Juri, Thanks. It'll good to have first a test that fails, showing the error and then applying the patch and showing that it works. I'll have a look later in the week if you don't beat me to it... Thanks -Vincent
Vincent Massol made changes -
Field Original Value New Value
Summary Update redeploy method for Tomcat container to perform actual undeploy and deploy instead of reload Fix redeploy method for Tomcat container to perform actual undeploy and deploy instead of reload
Issue Type Improvement [ 4 ] Bug [ 1 ]
Hide
Permalink
Aaron Digulla added a comment -

Here is another version which can be applied against 0.9-SNAPSHOT.

It also does undeploy+deploy instead of reload but it first checks if the undeploy is necessary (just like the normal undeploy target).

This allows to always run cargo:deployer-redeploy to deploy the app.

Show
Aaron Digulla added a comment - Here is another version which can be applied against 0.9-SNAPSHOT. It also does undeploy+deploy instead of reload but it first checks if the undeploy is necessary (just like the normal undeploy target). This allows to always run cargo:deployer-redeploy to deploy the app.
Aaron Digulla made changes -
Attachment redeploy.patch [ 23712 ]
Vincent Massol made changes -
Assignee Vincent Massol [ vmassol ]
Hide
Permalink
Vincent Massol added a comment -

Added a functional test and applied.

Show
Vincent Massol added a comment - Added a functional test and applied.
Vincent Massol made changes -
Fix Version/s 0.9 [ 12482 ]
Resolution Fixed [ 1 ]
Status Open [ 1 ] Closed [ 6 ]
Hide
Permalink
Amnon Khen added a comment -

Hi,
I also emailed this question to the people that worked on this bug.

It's written hhere that redeploy was implemented as an undeploy followed by a deploy.

Why does Cargo not allow the user to choose what to do? The TomcatManager class allows the user to choose whether to use the 'update' request parameter, but the AbstractTomcatManagerDeployer always uses this class with update=false.
Do you see a reason to prevent the user from updating a previously deployed war?

Thanks for your time and consideration,

Amnon Khen
amnon.is <at> gmail <dot> com

Show
Amnon Khen added a comment - Hi, I also emailed this question to the people that worked on this bug. It's written hhere that redeploy was implemented as an undeploy followed by a deploy. Why does Cargo not allow the user to choose what to do? The TomcatManager class allows the user to choose whether to use the 'update' request parameter, but the AbstractTomcatManagerDeployer always uses this class with update=false. Do you see a reason to prevent the user from updating a previously deployed war? Thanks for your time and consideration, Amnon Khen amnon.is <at> gmail <dot> com
Hide
Permalink
Matt Wringe added a comment -

could you please bring this up on the cargo mailing list instead of posting in the jira.
http://cargo.codehaus.org/Mailing+Lists

Show
Matt Wringe added a comment - could you please bring this up on the cargo mailing list instead of posting in the jira. http://cargo.codehaus.org/Mailing+Lists
Vincent Massol made changes -
Assignee Vincent Massol [ vmassol ]
Vincent Massol made changes -
Assignee Vincent Massol [ vmassol ]
Hide
Permalink
Vincent Massol added a comment -

I mistakenly removed myself as I thought the issue was still open...

Show
Vincent Massol added a comment - I mistakenly removed myself as I thought the issue was still open...

People

  • Assignee:
    Vincent Massol
    Reporter:
    Juri Artamonov
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: