Cargo
  1. Cargo
  2. CARGO-418

Allow <cargo> task to load configuration from external property file.

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8
    • Fix Version/s: 1.4.8
    • Component/s: Ant
    • Labels:
      None
    • Environment:
      Not of importance.
    • Complexity:
      Intermediate
    • Number of attachments :
      1

      Description

      The current implementation of the ANT <cargo> task has the disadvantage that the ANT script
      must still be aware which J2EE container is used (WebLogic, Resin, ...), because some J2EE-
      specific properties have to be set (e.g. cargo.weblogic.server for WebLogic).

      This is illustrated with build-cargo-call-current.xml (using container.properties).

      A better solution would perhaps be to add an additional attribute propertiesFile or similar
      on the <cargo> task that reads an external properties file from which the standard cargo
      attributes all starting with 'cargo.' can be loaded as well. This is illustrated with
      build-cargo-call-wishlist.xml.

      The only problem that remains is to chose an overriding mechanism, e.g. when the
      following is defined:

      <cargo propertiesFile="container.properties" containerId="tomcat5x" ...>
      ...
      </cargo>

      and when container.properties contains the property 'cargo.containerId=weblogic8x'.
      I would suggest in this case that the value of the properties value would be used
      instead of tomcat5x.

        Issue Links

          Activity

          Hide
          Davy Toch added a comment -

          Forgot to include the examples.

          Show
          Davy Toch added a comment - Forgot to include the examples.
          Hide
          Davy Toch added a comment -

          Of course the passed properties should only be local to the current <cargo> scope, allowing multiple <cargo> calls to be done from the same ANT script (e.g. if you would want to deploy to different J2EE containers from the same script).

          Show
          Davy Toch added a comment - Of course the passed properties should only be local to the current <cargo> scope, allowing multiple <cargo> calls to be done from the same ANT script (e.g. if you would want to deploy to different J2EE containers from the same script).
          Hide
          Savas Ali Tokmen added a comment -

          Committed revision 3830.

          Show
          Savas Ali Tokmen added a comment - Committed revision 3830.

            People

            • Assignee:
              Savas Ali Tokmen
              Reporter:
              Davy Toch
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: