Cargo

Allow passing a custom server.xml file when using a Tomcat Standalone local configuration

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.6
  • Fix Version/s: 1.0.2, 1.2.0
  • Component/s: Tomcat
  • Labels:
    None
  • Number of attachments :
    2

Issue Links

Activity

Hide
Vincent Massol added a comment -

Comment from Bill Dudney (copied from CARGO-223):

"
OK so what I did was added the ability to specify the server.xml file through a property and a path to the file to use.

If the file is specified it will be sent through the same set of ant filters as the one that comes out of the jar file. It might be over kill but I need it for WADI since I'm using cargo to launch 3 to 8 containers at a time. I did not want to have to keep a list of 8 server.xml files that only varried by port numbers since these classes have code that is already doing the right thing.

I patched ResourceUtils so I could continue to use the filter's.

I also added a way to set the @webapp.token@ through another property. When this is set the sever.xml from the jar file is used but the webapp token is replaced with the specified value instead of the one that is calculated.

I don't really like this because I had to copy the code that does the computing of the webapp.token value to my test class. Setting the manager class is still a better approach for me but I understand it won't scale.
"

Show
Vincent Massol added a comment - Comment from Bill Dudney (copied from CARGO-223): " OK so what I did was added the ability to specify the server.xml file through a property and a path to the file to use. If the file is specified it will be sent through the same set of ant filters as the one that comes out of the jar file. It might be over kill but I need it for WADI since I'm using cargo to launch 3 to 8 containers at a time. I did not want to have to keep a list of 8 server.xml files that only varried by port numbers since these classes have code that is already doing the right thing. I patched ResourceUtils so I could continue to use the filter's. I also added a way to set the @webapp.token@ through another property. When this is set the sever.xml from the jar file is used but the webapp token is replaced with the specified value instead of the one that is calculated. I don't really like this because I had to copy the code that does the computing of the webapp.token value to my test class. Setting the manager class is still a better approach for me but I understand it won't scale. "
Hide
Vincent Massol added a comment -

Bill, I don't undersand why you need to modify the @webapp.token@. If you're providing your own server.xml you certainly don't want Cargo to fill the webapp definitions for you as Cargo has no knowledge about your already installed webapps.

Show
Vincent Massol added a comment - Bill, I don't undersand why you need to modify the @webapp.token@. If you're providing your own server.xml you certainly don't want Cargo to fill the webapp definitions for you as Cargo has no knowledge about your already installed webapps.
Hide
Vincent Massol added a comment -

Leaving this out for 0.7 especially as we now have a Tomcat Existing Configuration implementation.

Show
Vincent Massol added a comment - Leaving this out for 0.7 especially as we now have a Tomcat Existing Configuration implementation.
Hide
Savas Ali Tokmen added a comment -

Fixed by linked issues.

Show
Savas Ali Tokmen added a comment - Fixed by linked issues.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: