Cargo

Allow Tomcat META-INF/context.xml to be used in expanded webapps

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.6
  • Component/s: Tomcat
  • Labels:
    None
  • Number of attachments :
    2

Description

I experimented a bit, and it seems Tomcat also accepts the context.xml file in
<config.dir>/Catalina/<hostname>/<context-path>.xml
This works quite well. Cargo just would have to check if it's an expanded
webapp and copy the context.xml over there, and don't generate the context
config in server.xml.

Implemented in attached patch.

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. CARGO-946 Deployment of expanded WAR with context.xml fails

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jan Zuchhold added a comment -

This patch adds a Test to TomcatSpecificTest and a testdata project tomcat-expanded-context.

Show
Jan Zuchhold added a comment - This patch adds a Test to TomcatSpecificTest and a testdata project tomcat-expanded-context.
Hide
Permalink
Vincent Massol added a comment -

Thanks a lot Jan. That was a very clean patch. I've simply removed the expandedtomcat-context testdata project as it doesn't seem to be really needed and reusing the tomcat-context one seems to do the trick (with one modification: the addtion of the docBase attribute).

Show
Vincent Massol added a comment - Thanks a lot Jan. That was a very clean patch. I've simply removed the expandedtomcat-context testdata project as it doesn't seem to be really needed and reusing the tomcat-context one seems to do the trick (with one modification: the addtion of the docBase attribute).

People

  • Assignee:
    Vincent Massol
    Reporter:
    Jan Zuchhold
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: