BTM

Report transaction timeout as Warning

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.3.3
  • Fix Version/s: 2.0.0
  • Labels:
    None
  • Number of attachments :
    0

Description

When a transaction timeout occurs the only information that is clearly stating the transaction was rollbacked due to a timeout is in DEBUG level.

In production, it's common to discard all DEBUG (or even INFO) messages, then it's difficult to known the reason of this timeout.

Could you change log level to WARN for the following message?

DEBUG (SessionId=,bitronix.tm.timer.TransactionTimeoutTask,33,bitronix-scheduler) [] marking a Bitronix Transaction with GTRID
[737072696E672D62746D00000128F259EEC600000000], status=ACTIVE, 1 resource(s) enlisted (started Tue Jun 01 09:11:39 CEST 2010) as timed out

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Johann Dupuis added a comment -

In TransactionTimeoutTask.java, replacing:

if (log.isDebugEnabled()) log.debug("marking " + transaction + " as timed out");

with

if (log.isWarnEnabled()) log.warn("marking " + transaction + " as timed out");

should do the job. Right?

Show
Johann Dupuis added a comment - In TransactionTimeoutTask.java, replacing: if (log.isDebugEnabled()) log.debug("marking " + transaction + " as timed out"); with if (log.isWarnEnabled()) log.warn("marking " + transaction + " as timed out"); should do the job. Right?
Hide
Permalink
Ludovic Orban added a comment -

Implemented in trunk.

TransactionTimeoutTask has been left untouched, the debug message in there really is for debug purpose so I added an extra warning log inside the BitronixTransaction.timeout() method instead.

Show
Ludovic Orban added a comment - Implemented in trunk. TransactionTimeoutTask has been left untouched, the debug message in there really is for debug purpose so I added an extra warning log inside the BitronixTransaction.timeout() method instead.

People

  • Assignee:
    Ludovic Orban
    Reporter:
    Johann Dupuis
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: