Boo

use implicit conversion operators

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: Compiler
  • Labels:
    None
  • Number of attachments :
    0

Description

A lot of types in the BCL (System.Decimal for instance) define implicit and explict conversion operators [1].

Those operators should be used by boo as apropriate for assignments, function argument evaluation (including overloaded operators) and cast expressions.

More explicitly, the following boo program:

def x2(value as Decimal):
return value*2

print(x2(4))
d as Decimal = 0

should be interpreted as:

def x2(value as Decimal):
return Decimal.op_Multiply(value, Decimal.op_Implicit(2))

print(x2(Decimal.op_Implicit(4)))
d as Decimal = Decimal.op_Implicit(0)

[1] http://msdn.microsoft.com/library/default.asp?url=/library/en-us/csspec/html/vclrfcsharpspec_10_9_3.asp

Issue Links

is depended upon by

Improvement - An improvement or enhancement to an existing feature or task. BOO-223 Improve Operator Override (and General Comparison)

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Open - The issue is open and ready for the assignee to start work on it.
is duplicated by

Improvement - An improvement or enhancement to an existing feature or task. BOO-362 Boo does not adhere to op_Implicit.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. BOO-651 Check both types for explicit conversion operator

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Resolved - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.
relates to

Improvement - An improvement or enhancement to an existing feature or task. BOO-206 Overload assignment operator, and implicit conversion

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Rodrigo B. de Oliveira added a comment -

leave for later to have a early 0.4 release.

Show
Rodrigo B. de Oliveira added a comment - leave for later to have a early 0.4 release.
Hide
Permalink
Doug H added a comment -

Here's a first stab at implementing this. Lemme know if there are problems. I haven't tested op_Explicit yet.

Show
Doug H added a comment - Here's a first stab at implementing this. Lemme know if there are problems. I haven't tested op_Explicit yet.
Hide
Permalink
Doug H added a comment -

2nd stab fixs bug + adds support for implicit conversion with operator overloading (see 3rd and 4th test cases under tests/testcases/integration/implicit*.boo).

The patch along with working bin and src builds are here: http://codehaus.org/~dholton/sandbox/
If it's not there later, also check: http://forge.novell.com/modules/xfmod/project/?boo-contrib

Show
Doug H added a comment - 2nd stab fixs bug + adds support for implicit conversion with operator overloading (see 3rd and 4th test cases under tests/testcases/integration/implicit*.boo). The patch along with working bin and src builds are here: http://codehaus.org/~dholton/sandbox/ If it's not there later, also check: http://forge.novell.com/modules/xfmod/project/?boo-contrib
Hide
Permalink
Rodrigo B. de Oliveira added a comment -

Doug,

I suggest we create a sandbox area in the repository so you can keep your patches/experiments readily available for people and for merging. What do you think?

Show
Rodrigo B. de Oliveira added a comment - Doug, I suggest we create a sandbox area in the repository so you can keep your patches/experiments readily available for people and for merging. What do you think?
Hide
Permalink
Doug H added a comment -

"I suggest we create a sandbox area in the repository so you can keep your patches/experiments readily available for people and for merging. What do you think?"

I've been doing that a year and nobody bothers with patching and merging and conflict editing to test them out (not that I blame them). So I'm putting patched builds at novell forge for now for testing.

Show
Doug H added a comment - "I suggest we create a sandbox area in the repository so you can keep your patches/experiments readily available for people and for merging. What do you think?" I've been doing that a year and nobody bothers with patching and merging and conflict editing to test them out (not that I blame them). So I'm putting patched builds at novell forge for now for testing.
Hide
Permalink
Doug H added a comment -

After applying patch, change this line NormalizeTypeAndMemberDefinitions.LeaveMethod:

if (node.Name.StartsWith("op_"))

to

if (node.Name != null && node.Name.StartsWith("op_"))

Some methods created by ast attributes do not have a name set. At least not until later in the pipeline.

Show
Doug H added a comment - After applying patch, change this line NormalizeTypeAndMemberDefinitions.LeaveMethod: if (node.Name.StartsWith("op_")) to if (node.Name != null && node.Name.StartsWith("op_")) Some methods created by ast attributes do not have a name set. At least not until later in the pipeline.
Hide
Permalink
Doug H added a comment -

This version of the patch is a rewrite. Covers more cases. It converts expressions to use op_Implicit during processmethodbodies instead of emitassembly, and it reduces a lot of code duplication.

Show
Doug H added a comment - This version of the patch is a rewrite. Covers more cases. It converts expressions to use op_Implicit during processmethodbodies instead of emitassembly, and it reduces a lot of code duplication.
Hide
Permalink
Doug H added a comment -

No response on list about this, and patch is over 6 months old.

Show
Doug H added a comment - No response on list about this, and patch is over 6 months old.

People

  • Assignee:
    Unassigned
    Reporter:
    Rodrigo B. de Oliveira
Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: