History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: BOO-627
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Rodrigo B. de Oliveira
Reporter: Daniel Grunwald
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Boo

BooPrinterVisitor generates invalid code for typed array literals with one element

Created: 04/Dec/05 12:07 PM   Updated: 20/Feb/06 07:16 AM
Component/s: Compiler
Affects Version/s: 0.7.5
Fix Version/s: 0.7.6

Time Tracking:
Not Specified

Environment: Boo 0.7.5


 Description  « Hide
The C# -> Boo converter converts
private static readonly sbyte[] EOL = new sbyte[] {0};
to
private static final EOL as (sbyte) = (of sbyte: 0,)

The trailing comma is invalid in typed array literals, BooPrinterVisitor should not output it (or the parser should ignore trailing commas).



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Doug H - 19/Feb/06 11:42 AM
Didn't realize there was a jira issue for this. I fixed this yesterday, although the parser should be adjusted I think to allow an optional trailing comma for any array or list literals.

Rodrigo B. de Oliveira - 20/Feb/06 07:16 AM
> ... although the parser should be adjusted I think to allow an optional trailing comma for any array or list literals.

Agreed.