[#BOO-1117] Allow compilation for Silverlight profile - jira.codehaus.org

Boo

Allow compilation for Silverlight profile

Created: 17/Jan/09 06:44 AM Updated: 18/Jan/09 01:06 AM Resolved: 18/Jan/09 01:06 AM

Return to search

Component/s:

Compiler

Affects Version/s:

0.8.2

Fix Version/s:

0.9

Time Tracking:

Not Specified

File Attachments:

BOO-1117.patch (2 kB)

Patch Submitted:

Yes

Description

« Hide

Currently Boo cannot compile with Silverlight profile (--nostdlib then references to Silverlight assemblies) because of some missing attributes that we check.

Attached patch fixes this. Testsuite does not regress.
However since I'm not sure why this code path was not enabled until now please confirm patch is ok to commit.

Sort Order:

Cedric Vivier made changes - 17/Jan/09 06:47 AM

Field	Original Value	New Value
Description	Currently Boo cannot compile with Silverlight profile (--nostdlib then references to Silverlight assemblies) because of some missing attributes that we check. Attached patch fixes this. Testsuite is obviously succeeded. However I'm not sure why this code path was not enabled until now so please confirm patch is ok to commit.	Currently Boo cannot compile with Silverlight profile (--nostdlib then references to Silverlight assemblies) because of some missing attributes that we check. Attached patch fixes this. Testsuite does not regress. However since I'm not sure why this code path was not enabled until now please confirm patch is ok to commit.

[ Permalink | « Hide ]

Cedric Vivier added a comment - 17/Jan/09 06:47 AM

Error was:

Entering Boo.Lang.Compiler.Steps.InitializeNameResolutionService
Leaving Boo.Lang.Compiler.Steps.InitializeNameResolutionService
BCE0106: Boo.Lang.Compiler.CompilerError: Failed to access the types defined in
assembly 'System.Windows, Version=2.0.5.0, Culture=neutral, PublicKeyToken=7cec8
5d7bea7798e' - (C:\Program Files\Microsoft SDKs\Silverlight\v2.0\Reference Assem
blies\System.Windows.dll): Could not load type 'System.Security.SecuritySafeCrit
icalAttribute' from assembly 'mscorlib, Version=2.0.0.0, Culture=neutral, Public
KeyToken=b77a5c561934e089'.. ---> System.TypeLoadException: Could not load type
'System.Security.SecuritySafeCriticalAttribute' from assembly 'mscorlib, Version
=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'.
   at System.ModuleHandle.ResolveType(Int32 typeToken, RuntimeTypeHandle* typeIn
stArgs, Int32 typeInstCount, RuntimeTypeHandle* methodInstArgs, Int32 methodInst
Count)
   at System.ModuleHandle.ResolveTypeHandle(Int32 typeToken, RuntimeTypeHandle[]
 typeInstantiationContext, RuntimeTypeHandle[] methodInstantiationContext)
   at System.Reflection.Module.ResolveType(Int32 metadataToken, Type[] genericTy
peArguments, Type[] genericMethodArguments)
   at System.Reflection.CustomAttribute.FilterCustomAttributeRecord(CustomAttrib
uteRecord caRecord, MetadataImport scope, Assembly& lastAptcaOkAssembly, Module
decoratedModule, MetadataToken decoratedToken, RuntimeType attributeFilterType,
Boolean mustBeInheritable, Object[] attributes, IList derivedAttributes, Runtime
Type& attributeType, RuntimeMethodHandle& ctor, Boolean& ctorHasParameters, Bool
ean& isVarArg)
   at System.Reflection.CustomAttribute.IsCustomAttributeDefined(Module decorate
dModule, Int32 decoratedMetadataToken, RuntimeType attributeFilterType, Boolean
mustBeInheritable)
   at System.Reflection.CustomAttribute.IsDefined(RuntimeType type, RuntimeType
caType, Boolean inherit)
   at System.RuntimeType.IsDefined(Type attributeType, Boolean inherit)
   at System.Attribute.IsDefined(MemberInfo element, Type attributeType, Boolean
 inherit)
   at System.Attribute.IsDefined(MemberInfo element, Type attributeType)
   at Boo.Lang.Compiler.TypeSystem.MetadataUtil.IsAttributeDefined(MemberInfo me
mber, Type attributeType)
   at Boo.Lang.Compiler.TypeSystem.TypeSystemServices.IsModule(Type type)
   at Boo.Lang.Compiler.TypeSystem.NamespaceEntity.Add(Type type)
   at Boo.Lang.Compiler.TypeSystem.NameResolutionService.CatalogPublicTypes(Type
[] types)
   at Boo.Lang.Compiler.TypeSystem.NameResolutionService.OrganizeAssemblyTypes(A
ssembly asm)
   at Boo.Lang.Compiler.Steps.InitializeNameResolutionService.OrganizeExternalNa
mespaces()

[ Show » ]

Cedric Vivier added a comment - 17/Jan/09 06:47 AM Error was:

Entering Boo.Lang.Compiler.Steps.InitializeNameResolutionService
Leaving Boo.Lang.Compiler.Steps.InitializeNameResolutionService
BCE0106: Boo.Lang.Compiler.CompilerError: Failed to access the types defined in
assembly 'System.Windows, Version=2.0.5.0, Culture=neutral, PublicKeyToken=7cec8
5d7bea7798e' - (C:\Program Files\Microsoft SDKs\Silverlight\v2.0\Reference Assem
blies\System.Windows.dll): Could not load type 'System.Security.SecuritySafeCrit
icalAttribute' from assembly 'mscorlib, Version=2.0.0.0, Culture=neutral, Public
KeyToken=b77a5c561934e089'.. ---> System.TypeLoadException: Could not load type
'System.Security.SecuritySafeCriticalAttribute' from assembly 'mscorlib, Version
=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'.
   at System.ModuleHandle.ResolveType(Int32 typeToken, RuntimeTypeHandle* typeIn
stArgs, Int32 typeInstCount, RuntimeTypeHandle* methodInstArgs, Int32 methodInst
Count)
   at System.ModuleHandle.ResolveTypeHandle(Int32 typeToken, RuntimeTypeHandle[]
 typeInstantiationContext, RuntimeTypeHandle[] methodInstantiationContext)
   at System.Reflection.Module.ResolveType(Int32 metadataToken, Type[] genericTy
peArguments, Type[] genericMethodArguments)
   at System.Reflection.CustomAttribute.FilterCustomAttributeRecord(CustomAttrib
uteRecord caRecord, MetadataImport scope, Assembly& lastAptcaOkAssembly, Module
decoratedModule, MetadataToken decoratedToken, RuntimeType attributeFilterType,
Boolean mustBeInheritable, Object[] attributes, IList derivedAttributes, Runtime
Type& attributeType, RuntimeMethodHandle& ctor, Boolean& ctorHasParameters, Bool
ean& isVarArg)
   at System.Reflection.CustomAttribute.IsCustomAttributeDefined(Module decorate
dModule, Int32 decoratedMetadataToken, RuntimeType attributeFilterType, Boolean
mustBeInheritable)
   at System.Reflection.CustomAttribute.IsDefined(RuntimeType type, RuntimeType
caType, Boolean inherit)
   at System.RuntimeType.IsDefined(Type attributeType, Boolean inherit)
   at System.Attribute.IsDefined(MemberInfo element, Type attributeType, Boolean
 inherit)
   at System.Attribute.IsDefined(MemberInfo element, Type attributeType)
   at Boo.Lang.Compiler.TypeSystem.MetadataUtil.IsAttributeDefined(MemberInfo me
mber, Type attributeType)
   at Boo.Lang.Compiler.TypeSystem.TypeSystemServices.IsModule(Type type)
   at Boo.Lang.Compiler.TypeSystem.NamespaceEntity.Add(Type type)
   at Boo.Lang.Compiler.TypeSystem.NameResolutionService.CatalogPublicTypes(Type
[] types)
   at Boo.Lang.Compiler.TypeSystem.NameResolutionService.OrganizeAssemblyTypes(A
ssembly asm)
   at Boo.Lang.Compiler.Steps.InitializeNameResolutionService.OrganizeExternalNa
mespaces()

Cedric Vivier made changes - 17/Jan/09 06:51 AM

Status

Open [ 1 ]

In Progress [ 3 ]

[ Permalink | « Hide ]

Rodrigo B. de Oliveira added a comment - 17/Jan/09 07:06 AM

Patch looks good.

[ Permalink | « Hide ]

Cedric Vivier added a comment - 18/Jan/09 01:06 AM

Fixed in rev. 3122

Cedric Vivier made changes - 18/Jan/09 01:06 AM

Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Resolved [ 5 ]