[#BOO-1094] Property getter/setter visibility is not checked nor emitted separately. - jira.codehaus.org

Boo

Property getter/setter visibility is not checked nor emitted separately.

Created: 03/Nov/08 04:29 AM Updated: 03/Nov/08 06:39 AM Resolved: 03/Nov/08 06:39 AM

Return to search

Component/s:

None

Affects Version/s:

0.8.2

Fix Version/s:

0.9

Time Tracking:

Not Specified

Testcase included:

yes

Description

« Hide

Following code compiles fine :

Title as string:
		get:
			return _title
		protected set:
			_title = value
	_title as string

But does not emit what is expected. It does not emit the setter as 'protected' but as 'public'.
Only the 'master' property visibility is taken into account.

Sort Order:

Cedric Vivier made changes - 03/Nov/08 04:30 AM

Field	Original Value	New Value
Description	Following code compiles fine : {code] Title as string: get: return _title protected set: _title = value _title as string {code} But does not emit what is expected. It does not emit the setter as 'protected' but as 'public'. Only the 'master' property visibility is taken into account.	Following code compiles fine : {code} Title as string: get: return _title protected set: _title = value _title as string {code} But does not emit what is expected. It does not emit the setter as 'protected' but as 'public'. Only the 'master' property visibility is taken into account.

[ Permalink | « Hide ]

Cedric Vivier added a comment - 03/Nov/08 05:00 AM

Actually the whole handling of getter/setter visibility is borken.
CheckMembersProtectionLevelStep checks only for the access relative to the root property node, so with either getter or setter different than the 'root' property node, a MethodAccessException is thrown by the runtime.

Cedric Vivier made changes - 03/Nov/08 05:02 AM

Summary

getter/setter visibility modifiers are ignored by EmitAssemblyStep

Property getter/setter visibility are not checked nor emitted separately.

Cedric Vivier made changes - 03/Nov/08 05:07 AM

Summary

Property getter/setter visibility are not checked nor emitted separately.

Property getter/setter visibility is not checked nor emitted separately.

[ Permalink | « Hide ]

Cedric Vivier added a comment - 03/Nov/08 06:39 AM

Fixed in rev. 3070

Cedric Vivier made changes - 03/Nov/08 06:39 AM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]