Maven Archetype
  1. Maven Archetype
  2. ARCHETYPE-378

Remove the parameter goalPrefix (and corresponding code) from the archetype:add-archetype-metadata mojo

    Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.1
    • Component/s: Plugin
    • Labels:
      None
    • Number of attachments :
      0

      Description

      As questioned in Archtypes and plugin prefix, it appears the parameter goalName of the add-archetype-metadata mojo exists merely due to copy&paste but has no real use in the context of archetypes. As such the parameter and its backing code should be removed to reduce confusion for end users and to keep the group-level metadata free from bogus plugin prefix mappings for archetypes.

        Activity

        Hide
        Herve Boutemy added a comment -

        the more I read the code, the more I ask myself: why does this add-archetype-metadata mojo ever exist?

        the whole thing, not only goalName, seems a copy, but this does not have any meaning for an archetype: an archetype is simply not a plugin, plugin mapping does not have any meaning, and LATEST isn't used

        IIUC, the whole class should be removed, and its lifecycle binding in maven-archetype packaging

        WDYT?

        Show
        Herve Boutemy added a comment - the more I read the code, the more I ask myself: why does this add-archetype-metadata mojo ever exist? the whole thing, not only goalName, seems a copy, but this does not have any meaning for an archetype: an archetype is simply not a plugin, plugin mapping does not have any meaning, and LATEST isn't used IIUC, the whole class should be removed, and its lifecycle binding in maven-archetype packaging WDYT?
        Hide
        Herve Boutemy added a comment -

        after some discussion and research, here are my results:

        • plugin mapping does not have any meaning for an archetype
        • LATEST update isn't used since for a long time, archetypes were packages as jar packaging, which does not update LATEST without any problem: maven-arhetype packaging is here only for integration-tests and update-local-catalog

        definitely, removing this mojo won't remove any functionality, only unneeded copy/paste

        I'm going to remove the mojo

        Show
        Herve Boutemy added a comment - after some discussion and research, here are my results: plugin mapping does not have any meaning for an archetype LATEST update isn't used since for a long time, archetypes were packages as jar packaging, which does not update LATEST without any problem: maven-arhetype packaging is here only for integration-tests and update-local-catalog definitely, removing this mojo won't remove any functionality, only unneeded copy/paste I'm going to remove the mojo
        Hide
        Herve Boutemy added a comment -

        done in r1158911

        Show
        Herve Boutemy added a comment - done in r1158911

          People

          • Assignee:
            Herve Boutemy
            Reporter:
            Benjamin Bentmann
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: