Maven Archetype

Should ask input for requiredProperty with defaultValue

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

It seems that if a requiredProperty is defined with a defaultValue, the generate mojo does not ask user input. In my opinion it should, just like it does it for the version.

DefaultArchetypeFactory lines 156-168 seem to be the culprit and I'll attach a patch that might fix this.

Issue Links

is duplicated by

New Feature - A new feature of the product, which has yet to be developed. ARCHETYPE-196 Default value like property 'version' at 2.0-alpha-3

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Raphaël Piéroni added a comment -

Grégory,

with generate goal, the first time, no default value is asked for.
when you answer N to confirmation, then then any property is asked for, proposing a default value.

If you are really interrested in this feature, please know that some people expressed their desire in the properties being defaulted without any question.
So if you really want, it, please consider asking for a poll on that subject on user (cross posting to dev)

Thanks,

Raphaël

Show
Raphaël Piéroni added a comment - Grégory, with generate goal, the first time, no default value is asked for. when you answer N to confirmation, then then any property is asked for, proposing a default value. If you are really interrested in this feature, please know that some people expressed their desire in the properties being defaulted without any question. So if you really want, it, please consider asking for a poll on that subject on user (cross posting to dev) Thanks, Raphaël
Hide
Permalink
Grégory Joseph added a comment -

I actually see value for all 3 cases ("fixed value" (ie the current "default"), "input with default" and "input"), while I find the idea of having to first fill in values, and then not confirm it to be able to change the defaults counter-intuitive.

Cheers,

-greg

Show
Grégory Joseph added a comment - I actually see value for all 3 cases ("fixed value" (ie the current "default"), "input with default" and "input"), while I find the idea of having to first fill in values, and then not confirm it to be able to change the defaults counter-intuitive. Cheers, -greg
Hide
Permalink
ant elder added a comment -

I also agree its counter intuitive like this, and having it prompt for the first time surely must be what most users would want and expect. I'd hunted and debugged this for hours before finding this jira and finding that it is possible to change the default value by answering N to the final confirmation prompt, that seems really obscure. If it really is wanted by some wouldn't it be better to have a separate option to disable the initial prompting?

Show
ant elder added a comment - I also agree its counter intuitive like this, and having it prompt for the first time surely must be what most users would want and expect. I'd hunted and debugged this for hours before finding this jira and finding that it is possible to change the default value by answering N to the final confirmation prompt, that seems really obscure. If it really is wanted by some wouldn't it be better to have a separate option to disable the initial prompting?
Hide
Permalink
ant elder added a comment -

See also http://jira.codehaus.org/browse/ARCHETYPE-200

Show
ant elder added a comment - See also http://jira.codehaus.org/browse/ARCHETYPE-200
Hide
Permalink
Dominique Jean-Prost added a comment -

Hello,

Although the package variable is required and has a default value (the groupId value), there is a prompt for it in the genration process.
So to my mind, following the same reasoning should implement a fix for this bug.

Show
Dominique Jean-Prost added a comment - Hello, Although the package variable is required and has a default value (the groupId value), there is a prompt for it in the genration process. So to my mind, following the same reasoning should implement a fix for this bug.
Hide
Permalink
Mykola Nikishov added a comment -

Any progress on this? Patch had been available for almost two years...

Show
Mykola Nikishov added a comment - Any progress on this? Patch had been available for almost two years...
Hide
Permalink
Edward Staub added a comment -

I would guess that no one wants to do it because of the controversy expressed by Raphaël in the first comment.

Did anyone do a poll? What was the outcome? Maybe a new attribute is needed.

Everyone who needs this should put a vote on it - there aren't very many.

Show
Edward Staub added a comment - I would guess that no one wants to do it because of the controversy expressed by Raphaël in the first comment. Did anyone do a poll? What was the outcome? Maybe a new attribute is needed. Everyone who needs this should put a vote on it - there aren't very many.
Hide
Permalink
vychtrle added a comment -

Ou my, I would so love to see this fixed... Doesn't make sense like this... It asks you first for artifactId, groupId, version and packaging.... then you have to say N to have a chance to change the custom properties from default values, BUT it asks you again for artifactId, groupId, version and packaging ... and then the properties finally ...

Show
vychtrle added a comment - Ou my, I would so love to see this fixed... Doesn't make sense like this... It asks you first for artifactId, groupId, version and packaging.... then you have to say N to have a chance to change the custom properties from default values, BUT it asks you again for artifactId, groupId, version and packaging ... and then the properties finally ...
Hide
Permalink
Nicolas Dupont added a comment - - edited

BTW, I've noticed that the generator will ask for requiredProperty with defaultValue if and only if the defaultValue contains a Velocity expression.
For instance, if your default value is com.my.project, you won't be asked, but if it is $

{groupId}

, you'll be.

Show
Nicolas Dupont added a comment - - edited BTW, I've noticed that the generator will ask for requiredProperty with defaultValue if and only if the defaultValue contains a Velocity expression. For instance, if your default value is com.my.project, you won't be asked, but if it is $ {groupId} , you'll be.

People

  • Assignee:
    Unassigned
    Reporter:
    Grégory Joseph
Vote (17)
Watch (13)

Dates

  • Created:
    Updated: