Activiti
  1. Activiti
  2. ACT-599

BPMN20ExportMarshaller generates wrong id for startEvent and endEvent elements of subProcesses

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.2
    • Fix Version/s: 5.3
    • Component/s: Designer
    • Labels:
      None
    • Number of attachments :
      2

      Description

      The id attribute of startEvent and endEvent of subprocesses should be prefixed with the subprocess id. Currently invalid BPMN is generated when using subprocesses, see attached bpmn file

      1. ACT-599.diff
        1 kB
        Hinse ter Schuur
      2. reproduction.activiti.bpmn20.xml
        2 kB
        Hinse ter Schuur

        Issue Links

          Activity

          Hide
          Hinse ter Schuur added a comment -

          The attached patch should fix this issue

          Show
          Hinse ter Schuur added a comment - The attached patch should fix this issue
          Hide
          Tiese Barrell added a comment -

          Thanks for reporting this and supplying a patch. By looking at the patch however, I'm concerned about maintenance. Wouldn't we have to do this work manually for each element generated in the subprocess? Maybe it would be preferable to create a method that recalculates ids for all elements or alternatively to create process/subprocess unique ids straight from the get-go so this problem can be avoided.

          Show
          Tiese Barrell added a comment - Thanks for reporting this and supplying a patch. By looking at the patch however, I'm concerned about maintenance. Wouldn't we have to do this work manually for each element generated in the subprocess? Maybe it would be preferable to create a method that recalculates ids for all elements or alternatively to create process/subprocess unique ids straight from the get-go so this problem can be avoided.
          Hide
          Kostas Pagratis added a comment -

          Could you please provide a patched 5.2 binary? This is a blocker for me on a major project.

          Show
          Kostas Pagratis added a comment - Could you please provide a patched 5.2 binary? This is a blocker for me on a major project.
          Hide
          Tiese Barrell added a comment -

          Tijs,

          this issue is linked to ACT-627, which you have resolved. Could you resolve this one as well if you think it's covered by the fix for ACT-599?

          Show
          Tiese Barrell added a comment - Tijs, this issue is linked to ACT-627 , which you have resolved. Could you resolve this one as well if you think it's covered by the fix for ACT-599 ?
          Hide
          Tiese Barrell added a comment -

          Kostas,

          this hasn't been fixed in 0.7.0. It has been resolved for the next release. You might be able to replace the org.activiti.designer.export.bpmn20 bundle manually by downloading it from the update site, once the next release is there. The URL will be: http://activiti.org/designer/update/plugins/org.activiti.designer.export.bpmn20_<version>.jar Note that this may yield version problems, but it will be worth a try if it's a real problem for you.

          Show
          Tiese Barrell added a comment - Kostas, this hasn't been fixed in 0.7.0. It has been resolved for the next release. You might be able to replace the org.activiti.designer.export.bpmn20 bundle manually by downloading it from the update site, once the next release is there. The URL will be: http://activiti.org/designer/update/plugins/org.activiti.designer.export.bpmn20_ <version>.jar Note that this may yield version problems, but it will be worth a try if it's a real problem for you.
          Hide
          Tijs Rademakers added a comment -

          The sub process id is now generated for start and end events in sub processes

          Show
          Tijs Rademakers added a comment - The sub process id is now generated for start and end events in sub processes

            People

            • Assignee:
              Tijs Rademakers
              Reporter:
              Hinse ter Schuur
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: