Activiti
  1. Activiti
  2. ACT-246

Missing warning when process has a construct which is unsupported.

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 5.0.rc1
    • Fix Version/s: 5.0.rc1
    • Component/s: Engine
    • Labels:
      None
    • Patch Submitted:
      Yes
    • Number of attachments :
      2

      Description

      No warning is emitted when unsupported sendTask is used in process.

      Attach is a patch to address this and it has been run through regression tests.
      Fix is trivial but should be helpful to newbies.

        Activity

        Hide
        Farrukh Najmi added a comment -

        There are a few minor issues with the fix that was committed that were not there in the patch that I submitted:

        • Many spurious warnings emitted about sub-elements in process element that are actually supported (e.g. startEvent)
        • Only filename, line and column numbers are emitted but element name is not emitted making it necessary to find the source file and look up what is not supported.

        I will attach a BPMN2 file that shows these errors though I suspect most any file would do.

        Show
        Farrukh Najmi added a comment - There are a few minor issues with the fix that was committed that were not there in the patch that I submitted: Many spurious warnings emitted about sub-elements in process element that are actually supported (e.g. startEvent) Only filename, line and column numbers are emitted but element name is not emitted making it necessary to find the source file and look up what is not supported. I will attach a BPMN2 file that shows these errors though I suspect most any file would do.
        Hide
        Farrukh Najmi added a comment -

        Here is the listing with many spurious warning....

        WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 40 | column 64
        Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings
        WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 58 | column 75
        Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings
        WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 125 | column 73
        Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings
        WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 140 | column 184
        Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings
        WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 141 | column 184
        Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings
        WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 142 | column 184
        Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings
        WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 143 | column 184
        Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings
        WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 144 | column 184
        Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings
        WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 145 | column 184
        Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings
        WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 146 | column 200
        Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings
        WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 149 | column 209
        Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings
        WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 152 | column 201
        Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings
        WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 155 | column 184
        Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings
        WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 156 | column 184
        Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings
        WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 157 | column 199
        Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings
        WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 160 | column 199
        10:36:43,304  INFO GovernanceManagerTest:69 - deployed with deploymentId: 2001
        
        Show
        Farrukh Najmi added a comment - Here is the listing with many spurious warning.... WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 40 | column 64 Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 58 | column 75 Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 125 | column 73 Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 140 | column 184 Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 141 | column 184 Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 142 | column 184 Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 143 | column 184 Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 144 | column 184 Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 145 | column 184 Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 146 | column 200 Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 149 | column 209 Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 152 | column 201 Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 155 | column 184 Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 156 | column 184 Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 157 | column 199 Oct 22, 2010 10:36:43 AM org.activiti.engine.impl.util.xml.Parse logWarnings WARNING: Ignoring unsupported activity type | bpmn/defaultGovernanceCollaboration.bpmn20.xml | line 160 | column 199 10:36:43,304 INFO GovernanceManagerTest:69 - deployed with deploymentId: 2001
        Hide
        Joram Barrez added a comment -

        Yes, I saw that too this morning. I changed the if-else clause in revision 1054.

        Could your verify that it is fixed by the trunk version?

        Show
        Joram Barrez added a comment - Yes, I saw that too this morning. I changed the if-else clause in revision 1054. Could your verify that it is fixed by the trunk version?
        Hide
        Farrukh Najmi added a comment -

        The spurious warning issue It is indeed fixed. My apologies. Thanks.

        Show
        Farrukh Najmi added a comment - The spurious warning issue It is indeed fixed. My apologies. Thanks.

          People

          • Assignee:
            Joram Barrez
            Reporter:
            Farrukh Najmi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: