Activiti

[Eclipse] Diagram modifications removes data in XML file

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 5.8
  • Fix Version/s: 5.10
  • Component/s: Designer
  • Labels:
    None
  • Environment:
    Eclipse Indigo Service Release 1, Build id: 20110916-0149, WinXP SP3, Activiti Eclipse BPMN 2.0 Designer 5.8.0.
  • Number of attachments :
    0

Description

Hello,

I'am using Eclipse to create my Workflow. If I change something in the diagram (ie : just move the endEvent) and save. All code inside <activiti:string> is deleted.

Please look at the "<activiti:string>execution.setVariable('sgfwf_approveRejectOutcome',task.getVariable('sgfwf_approveRejectOutcome'));</activiti:string>"

xml file before a change in diagram
Code:
<?xml version="1.0" encoding="UTF-8"?>
<definitions xmlns="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:activiti="http://activiti.org/bpmn" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:omgdc="http://www.omg.org/spec/DD/20100524/DC" xmlns:omgdi="http://www.omg.org/spec/DD/20100524/DI" typeLanguage="http://www.w3.org/2001/XMLSchema" expressionLanguage="http://www.w3.org/1999/XPath" targetNamespace="http://activiti.org/bpmn20">
<process id="Simple" name="Adhoc Activiti Process 08:33">
<startEvent id="start" name="Start" activiti:formKey="sgfwf:submitStart"></startEvent>
<userTask id="modifyReview" name="Add/Modify Data, Accept or Reject" activiti:assignee="$

{bpm_assignee.properties.userName}" activiti:formKey="sgfwf:modifyReviewTask">
<extensionElements>
<activiti:taskListener event="complete" class="org.alfresco.repo.workflow.activiti.tasklistener.ScriptTaskListener">
<activiti:field name="script">
<activiti:string>execution.setVariable('sgfwf_approveRejectOutcome',task.getVariable('sgfwf_approveRejectOutcome'));</activiti:string>
</activiti:field>


xml file after a change in diagram
Code:
<?xml version="1.0" encoding="UTF-8"?>
<definitions xmlns="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:activiti="http://activiti.org/bpmn" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:omgdc="http://www.omg.org/spec/DD/20100524/DC" xmlns:omgdi="http://www.omg.org/spec/DD/20100524/DI" typeLanguage="http://www.w3.org/2001/XMLSchema" expressionLanguage="http://www.w3.org/1999/XPath" targetNamespace="http://activiti.org/bpmn20">
<process id="MyProcess" name="Adhoc Activiti Process 08:33">
<startEvent id="start" name="Start" activiti:formKey="sgfwf:submitStart"></startEvent>
<userTask id="modifyReview" name="Add/Modify Data, Accept or Reject" activiti:assignee="${bpm_assignee.properties.userName}

" activiti:formKey="sgfwf:modifyReviewTask">
<extensionElements>
<activiti:taskListener event="complete" class="org.alfresco.repo.workflow.activiti.tasklistener.ScriptTaskListener">
<activiti:field name="script">
<activiti:string></activiti:string>
</activiti:field>

Thank you

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Xavier Sudan added a comment -

Bug appears in Eclipse... not in the Activiti Designer

Show
Xavier Sudan added a comment - Bug appears in Eclipse... not in the Activiti Designer
Hide
Permalink
Tijs Rademakers added a comment -

We now use only 1 model file, this is the bpmn20.xml

Show
Tijs Rademakers added a comment - We now use only 1 model file, this is the bpmn20.xml
Hide
Permalink
Ron K added a comment -

Repeating the information from the forum:

This problem is quite severe, as the designer is modifying the XML file causing loss of information.

In our case, the "name" attributes of every sequenceFlow is being erased from the file. Note this happens
when the (.BPMN) file is opened in the designer in Eclipse. When saving the file, the attributes stay intact.

So to see this issue, create a new flow in the designer, give a name to some sequenceFlow, save the file
and close the Editor. Now re-open the file and inspect (both the diagram and the XML text) - the names are gone.

It may be that other elements are being erased as well - we only checked this particular one.

Show
Ron K added a comment - Repeating the information from the forum: This problem is quite severe, as the designer is modifying the XML file causing loss of information. In our case, the "name" attributes of every sequenceFlow is being erased from the file. Note this happens when the (.BPMN) file is opened in the designer in Eclipse. When saving the file, the attributes stay intact. So to see this issue, create a new flow in the designer, give a name to some sequenceFlow, save the file and close the Editor. Now re-open the file and inspect (both the diagram and the XML text) - the names are gone. It may be that other elements are being erased as well - we only checked this particular one.
Hide
Permalink
Ron K added a comment -

BTW, this seems to be targeted for fixing in 5.10 (01/Aug/12) - but until then we cannot use the designer at
all as it is removing information from our BPMN files. Perhaps it's worth considering to issue a fix before August.

Show
Ron K added a comment - BTW, this seems to be targeted for fixing in 5.10 (01/Aug/12) - but until then we cannot use the designer at all as it is removing information from our BPMN files. Perhaps it's worth considering to issue a fix before August.
Hide
Permalink
Tijs Rademakers added a comment -

I've fixed this bug on trunk a few minutes ago. I'm planning to do a 5.9.1 release in a couple of weeks with these kind of bug fixes.

Show
Tijs Rademakers added a comment - I've fixed this bug on trunk a few minutes ago. I'm planning to do a 5.9.1 release in a couple of weeks with these kind of bug fixes.

People

  • Assignee:
    Tijs Rademakers
    Reporter:
    Xavier Sudan
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: